* [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang
@ 2021-06-04 2:27 Gustavo A. R. Silva
2021-06-04 18:21 ` Kees Cook
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-06-04 2:27 UTC (permalink / raw)
To: Finn Thain, Michael Schmitz, James E.J. Bottomley,
Martin K. Petersen
Cc: linux-scsi, linux-kernel, Gustavo A. R. Silva, linux-hardening,
Kees Cook
In preparation to enable -Wimplicit-fallthrough for Clang, fix
a fall-through warning by replacing a /* fallthrough */ comment
with the new pseudo-keyword macro fallthrough;
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
JFYI: We had thousands of these sorts of warnings and now we are down
to just 22 in linux-next. This is one of those last remaining
warnings.
drivers/scsi/NCR5380.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 8aa964cd54df..3baadd068768 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -1816,7 +1816,7 @@ static void NCR5380_information_transfer(struct Scsi_Host *instance)
switch (tmp) {
case ABORT:
set_host_byte(cmd, DID_ABORT);
- /* fallthrough */
+ fallthrough;
case COMMAND_COMPLETE:
/* Accept message by clearing ACK */
sink = 1;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang
2021-06-04 2:27 [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang Gustavo A. R. Silva
@ 2021-06-04 18:21 ` Kees Cook
2021-06-08 2:23 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-06-04 18:21 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Finn Thain, Michael Schmitz, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel, linux-hardening
On Thu, Jun 03, 2021 at 09:27:52PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> a fall-through warning by replacing a /* fallthrough */ comment
> with the new pseudo-keyword macro fallthrough;
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Thanks!
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang
2021-06-04 2:27 [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang Gustavo A. R. Silva
2021-06-04 18:21 ` Kees Cook
@ 2021-06-08 2:23 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-06-08 2:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Finn Thain, Michael Schmitz, James E.J. Bottomley,
Martin K. Petersen, linux-scsi, linux-kernel, linux-hardening,
Kees Cook
Gustavo,
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a
> fall-through warning by replacing a /* fallthrough */ comment with the
> new pseudo-keyword macro fallthrough;
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang
2021-06-04 2:27 [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang Gustavo A. R. Silva
2021-06-04 18:21 ` Kees Cook
2021-06-08 2:23 ` Martin K. Petersen
@ 2021-06-16 3:48 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2021-06-16 3:48 UTC (permalink / raw)
To: Michael Schmitz, Gustavo A. R. Silva, James E.J. Bottomley,
Finn Thain
Cc: Martin K . Petersen, Kees Cook, linux-scsi, linux-hardening,
linux-kernel
On Thu, 3 Jun 2021 21:27:52 -0500, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix
> a fall-through warning by replacing a /* fallthrough */ comment
> with the new pseudo-keyword macro fallthrough;
Applied to 5.14/scsi-queue, thanks!
[1/1] scsi: NCR5380: Fix fall-through warning for Clang
https://git.kernel.org/mkp/scsi/c/61f4f11b48f9
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-16 3:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-04 2:27 [PATCH][next] scsi: NCR5380: Fix fall-through warning for Clang Gustavo A. R. Silva
2021-06-04 18:21 ` Kees Cook
2021-06-08 2:23 ` Martin K. Petersen
2021-06-16 3:48 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox