From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D55AC4743E for ; Fri, 4 Jun 2021 17:27:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 418AC61400 for ; Fri, 4 Jun 2021 17:27:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231196AbhFDR3Y (ORCPT ); Fri, 4 Jun 2021 13:29:24 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:33689 "EHLO mail-ed1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229778AbhFDR3X (ORCPT ); Fri, 4 Jun 2021 13:29:23 -0400 Received: by mail-ed1-f53.google.com with SMTP id f5so7014724eds.0 for ; Fri, 04 Jun 2021 10:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yQu4ZlSzEBr4vf2dWTW2YpYlkQS0idkpyI2C1hfoXug=; b=BFraaEIaKvQvAhBn08S1/i0KIziEiLFL1qJCYfHnBAaNRdGUyv3PPHBhk076NgNi0L HLwuqaBi3XdSp+YyjijaIqKGK2uegTOBlfU6GlE8TpiDgAIh4OzAe6SZbrki3HLf9Lv6 fFPggfTWEL++TBHlhZyAU+6D3mcTUnAefNyEejNa71MP2JSXRrdOmPpG++0/LjfWjpqD rjXKsIo7nRzoRyToyrPYuW0/izoqFcAE8KMINv1iFY6ibeF9vA+1sn7fgdohxCML+Wtw 0a/Yp/Y5gwCmw6DueEvSLbLsAvG70TGPSzREDuIPbHnACi6/DjG3pDS3023bt/HQkWQ0 zcDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yQu4ZlSzEBr4vf2dWTW2YpYlkQS0idkpyI2C1hfoXug=; b=mvfTMSMF9ITRJ3jXItveZUvrpgVJuLcQHhtqhchRGSpQi9kDY+/O5bmf7BD2Xs9s8A TNxjDmcnw3s0f9CNicrhk8ZA02HZcYL+8bFnC4w8FrgfWITZKn2IVBRf07q4+ggLUg2a qXI+xJRjDlv8dFNwWbuB6TOaV4lcxmvkjZueXvXlbDguvT5EBYUdjilVDsesxocbSbon hfS3BP44eSIO37ZENnXhu5gFN7d19GbsAQ9lGPf0mS1+yEkqMlO7eUmjNV2lFRrzdL/y jXdC6TqVifMVAp87q9xsYcGHDcdRxIKzUpov7dkeB9yxGRfKLPYi2eorkyD+M+A73wEV NfoA== X-Gm-Message-State: AOAM533VQs33p/CBvjPcxLBCaXTXg/+DGnckWEGOJAEtknSXEEGqmPHx IVm03dp5nSvxkAEYu7kFDFw= X-Google-Smtp-Source: ABdhPJxqm28tqKIRf3lvRa9hVIxcJ7lg+F4G1xZlfJG40omB+OUIg1fx6AHvl/B6vp64bs+C3rSh7Q== X-Received: by 2002:aa7:da94:: with SMTP id q20mr5905874eds.310.1622827596449; Fri, 04 Jun 2021 10:26:36 -0700 (PDT) Received: from agape.jhs ([5.171.80.153]) by smtp.gmail.com with ESMTPSA id u17sm3478663edx.16.2021.06.04.10.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 10:26:36 -0700 (PDT) Date: Fri, 4 Jun 2021 19:26:33 +0200 From: Fabio Aiuto To: Guenter Roeck Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: Use list iterators and helpers Message-ID: <20210604172632.GA1526@agape.jhs> References: <20210428173301.149619-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210428173301.149619-1-linux@roeck-us.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Guenter, On Wed, Apr 28, 2021 at 10:33:01AM -0700, Guenter Roeck wrote: > The rtl8723bs driver manually re-implements list helper functions > and macros in various ways. Replace with existing list helpers. I'm testing rtl8723bs on a baytrail tablet (Lenovo Ideapad MIIX 300-10IBY) and applying the tag staging-5.13-rc4, loading r8723bs makes the whole system freezing while trying to connect to local AP. Only a power off is allowed. I found that commit b3cd518c5abd42fbc747ef55a5fdc40bf7bf01c0 (staging: rtl8723bs: Use list iterators and helpers) introduced the bug. I'm trying to find out what's wrong with this patch, have you any suggestions? thank you, fabio