RE: [PATCH 3/4] ASoC: intel: sof_cs42l42: add support for jsl_cs4242_mx98360a

Lu, Brent
2021-06-07T14:29:32Z

> On 6/5/21 7:41 PM, Brent Lu wrote:
> > This patch adds driver data for jsl_cs4242_mx98360a which supports two
> > max98360a speaker amplifiers on SSP1 and cs42l42 headphone codec on
> > SSP0 running on JSL platform. DAI format is leveraged from sof_rt5682
> > machine driver to reuse the topology.
>
> This also looks like we have two topologies configuring the same DAIs
> differently on different platforms.
>
> Why can't we pick one configuration that would work in all cases?
>

The comment just say we are reusing rt5685's sof-jsl-rt5682-mx98360a.tplg.
This patch does not care about the dai sequence. Maybe I should reword the
commit log.

Regards,
Brent

> > Also use module device table to replace module alias.
>
> Humm, this looks like a missing dependency, I modified this a while ago.
>