From: Dave Chinner <david@fromorbit.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
linux-xfs@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the xfs tree
Date: Mon, 7 Jun 2021 11:15:59 +1000 [thread overview]
Message-ID: <20210607011559.GA664593@dread.disaster.area> (raw)
In-Reply-To: <20210607104819.2c032c75@canb.auug.org.au>
On Mon, Jun 07, 2021 at 10:48:19AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the xfs tree, today's linux-next build (powerpc_ppc64
> defconfig) produced this warning:
>
> fs/xfs/libxfs/xfs_ialloc.c: In function 'xfs_difree_finobt':
> fs/xfs/libxfs/xfs_ialloc.c:2032:20: warning: unused variable 'agi' [-Wunused-variable]
> 2032 | struct xfs_agi *agi = agbp->b_addr;
> | ^~~
>
> Not sure how this came about, but somehow DEBUG has been turned off
> which exposes this.
I think I replaced all the agi->agi_seqno usages in that function
with pag->pag_agno and so now the agi structure is only accessed via
debug functions. The debug code should now pass perag structures
rather than raw AGI structures to check the free inode counts....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2021-06-07 1:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-07 0:48 linux-next: build warning after merge of the xfs tree Stephen Rothwell
2021-06-07 1:15 ` Dave Chinner [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-13 4:58 Stephen Rothwell
2026-01-13 7:04 ` Christoph Hellwig
[not found] <D20pUU7kdgWfIpAYmLR776cP2sU4_NhTrc4Fasx5DbMewO7J6UW6QX_81athF3DSSPP2tZiEZNid_Rlin4p6lw==@protonmail.internalid>
2025-09-08 8:04 ` Stephen Rothwell
2025-09-16 10:22 ` Carlos Maiolino
[not found] <95VzqAdwXL6uADPxQWGQV9LD2OtK9bUX7if_opYIYTcdIroqe7176LhnAst-sIYFTfU2tgwJknumIwzvYvxyTQ==@protonmail.internalid>
2025-04-22 10:25 ` Stephen Rothwell
2025-04-22 10:46 ` Carlos Maiolino
2025-04-22 11:38 ` Hans Holmberg
2024-02-23 4:36 Stephen Rothwell
2024-02-23 6:35 ` Christoph Hellwig
2024-02-23 8:55 ` Mauro Carvalho Chehab
2024-02-23 14:06 ` Christoph Hellwig
2024-02-24 9:07 ` Akira Yokosawa
2024-02-26 10:57 ` Christoph Hellwig
2021-02-08 12:44 Stephen Rothwell
2021-01-24 22:55 Stephen Rothwell
2021-01-25 13:26 ` Brian Foster
2021-01-27 3:14 ` Darrick J. Wong
2020-05-08 1:15 Stephen Rothwell
2020-01-16 0:37 Stephen Rothwell
2020-01-15 22:12 Stephen Rothwell
2020-01-24 2:47 ` Stephen Rothwell
2020-01-24 4:17 ` Darrick J. Wong
2017-10-31 22:42 Stephen Rothwell
2017-08-31 0:07 Stephen Rothwell
2017-08-31 10:30 ` Brian Foster
2017-08-31 14:57 ` Darrick J. Wong
2017-08-31 15:22 ` Brian Foster
2017-08-31 15:41 ` Darrick J. Wong
2017-08-31 21:32 ` Dave Chinner
2010-03-04 0:19 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607011559.GA664593@dread.disaster.area \
--to=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox