Re: [PATCH v10] mm: slub: move sysfs slab alloc/free interfaces to debugfs

Andy Shevchenko
2021-06-07T16:43:50Z

On Mon, Jun 7, 2021 at 4:55 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:
> On 6/7/2021 2:01 AM, Andy Shevchenko wrote:
> > On Sun, Jun 6, 2021 at 7:16 PM Faiyaz Mohammed <faiyazm@codeaurora.org> wrote:

...

> >> + if (num_online_cpus() > 1 &&
> >> + !cpumask_empty(to_cpumask(l->cpus)))
> >
> > One line?
> >
> I have split the line because it is crossing the 80 columns. In this
> case it's okay to cross 80 columns?

For how many characters? If it's 3 or 4 or so, it's fine to have it on
one line. Use common sense here.

...

> >> + debugfs_remove_recursive(debugfs_lookup(s->name,
> >> + slab_debugfs_root));
> >
> > One line?
> >
> Same here!

Same here.

--
With Best Regards,
Andy Shevchenko