From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23501C47094 for ; Mon, 7 Jun 2021 13:12:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BF4E61185 for ; Mon, 7 Jun 2021 13:12:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbhFGNOb (ORCPT ); Mon, 7 Jun 2021 09:14:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbhFGNO3 (ORCPT ); Mon, 7 Jun 2021 09:14:29 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68373C061766; Mon, 7 Jun 2021 06:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=mzx+toA+I5GhMZJQ4bshpMENsBCltPEDS9fQ3Twfj7g=; b=bd0/P2zv8OxN2aVXSWnOUmYg/ aAmWH4AskdREZQW0GRs6yatKOr8pzi8lUzSILehQ1+JrS469ZEehPY66eojybpFjQcaFuQIATEL1G smkIGo30rk+3bnoIdEWQn1nLjOBIgeewLXNrg75mpVuaANWFym9dPQlraYGiex+6ZtpDlzK0zhsH7 gg0CCwD7Lm4LAl6tcmC5SfXNVMqLHF8K5kE4DTtyJH7QA5kQgpdP2kvB2Nl60FdgDIToKC+LbNfKV wFDsi20DA506bpZ3g2fAoooHoCR8x+iD2uAYipfJ048acaFGSssrrrtLZyxqZtV4oI1NgucOXF6vE xreUBIc5w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44794) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqF3Q-0000YM-At; Mon, 07 Jun 2021 14:12:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lqF3P-0005xU-Vc; Mon, 07 Jun 2021 14:12:31 +0100 Date: Mon, 7 Jun 2021 14:12:31 +0100 From: "Russell King (Oracle)" To: Steen Hegelund Cc: "David S. Miller" , Jakub Kicinski , Andrew Lunn , Microchip Linux Driver Support , Alexandre Belloni , Madalin Bucur , Mark Einon , Masahiro Yamada , Arnd Bergmann , Philipp Zabel , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjarni Jonasson , Lars Povlsen Subject: Re: [PATCH net-next v3 04/10] net: sparx5: add port module support Message-ID: <20210607131231.GF22278@shell.armlinux.org.uk> References: <20210604085600.3014532-1-steen.hegelund@microchip.com> <20210604085600.3014532-5-steen.hegelund@microchip.com> <20210607092136.GA22278@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 07, 2021 at 02:46:44PM +0200, Steen Hegelund wrote: > Hi Russell, > > Thanks for your comments. > > On Mon, 2021-06-07 at 10:21 +0100, Russell King (Oracle) wrote: > > It looks to me like the phylink code in your patch series is based on > > an older version of phylink and hasn't been updated for the split PCS > > support - you seem to be munging the PCS parts in with the MAC > > callbacks. If so, please update to the modern way of dealing with this. > > > > If that isn't the case, please explain why you are not using the split > > PCS support. > > I need to be able to let the user set the speed to get the link up. > > So far I have only been able to get the user configured speeds via the mac_ops, but if this is also > possible via the pcs_ops, there should not anything preventing me from using these ops instead. > > Will the pcs_ops also support this? I really don't understand what you're saying here, so I can't answer. What exactly do you mean "user configured speeds" ? Please give examples of exactly what you're wanting to do. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!