public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Hulk Robot <hulkci@huawei.com>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Zhen Lei <thunder.leizhen@huawei.com>
Subject: [for-linus][PATCH 1/5] tools/bootconfig: Fix error return code in apply_xbc()
Date: Wed, 09 Jun 2021 20:33:45 -0400	[thread overview]
Message-ID: <20210610003736.014523726@goodmis.org> (raw)
In-Reply-To: 20210610003344.783752614@goodmis.org

From: Zhen Lei <thunder.leizhen@huawei.com>

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Link: https://lkml.kernel.org/r/20210508034216.2277-1-thunder.leizhen@huawei.com

Fixes: a995e6bc0524 ("tools/bootconfig: Fix to check the write failure correctly")
Reported-by: Hulk Robot <hulkci@huawei.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
---
 tools/bootconfig/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/bootconfig/main.c b/tools/bootconfig/main.c
index 7362bef1a368..6cd6080cac04 100644
--- a/tools/bootconfig/main.c
+++ b/tools/bootconfig/main.c
@@ -399,6 +399,7 @@ static int apply_xbc(const char *path, const char *xbc_path)
 	}
 	/* TODO: Ensure the @path is initramfs/initrd image */
 	if (fstat(fd, &stat) < 0) {
+		ret = -errno;
 		pr_err("Failed to get the size of %s\n", path);
 		goto out;
 	}
-- 
2.30.2

  reply	other threads:[~2021-06-10  0:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10  0:33 [for-linus][PATCH 0/5] tracing: Fixes for 5.13 Steven Rostedt
2021-06-10  0:33 ` Steven Rostedt [this message]
2021-06-10  0:33 ` [for-linus][PATCH 2/5] tools/bootconfig: Fix a build error accroding to undefined fallthrough Steven Rostedt
2021-06-10  0:33 ` [for-linus][PATCH 3/5] ftrace: Do not blindly read the ip address in ftrace_bug() Steven Rostedt
2021-06-10  0:33 ` [for-linus][PATCH 4/5] tracing: Correct the length check which causes memory corruption Steven Rostedt
2021-06-10  0:33 ` [for-linus][PATCH 5/5] recordmcount: Correct st_shndx handling Steven Rostedt
2021-06-10  8:25   ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610003736.014523726@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=hulkci@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=thunder.leizhen@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox