From: Vadym Kochan <vadym.kochan@plvision.eu>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>
Cc: Taras Chornyi <tchornyi@marvell.com>,
linux-kernel@vger.kernel.org,
Mickey Rachamim <mickeyr@marvell.com>,
Vadym Kochan <vkochan@marvell.com>
Subject: Re: [PATCH v2 0/3] net: marvell: prestera: add LAG support
Date: Thu, 10 Jun 2021 19:08:28 +0300 [thread overview]
Message-ID: <20210610160828.GB29315@plvision.eu> (raw)
In-Reply-To: <20210610154311.23818-1-vadym.kochan@plvision.eu>
Sorry, I did not mark it with a "net-next", will resend.
On Thu, Jun 10, 2021 at 06:43:08PM +0300, Vadym Kochan wrote:
> From: Vadym Kochan <vkochan@marvell.com>
>
> The following features are supported:
>
> - LAG basic operations
> - create/delete LAG
> - add/remove a member to LAG
> - enable/disable member in LAG
> - LAG Bridge support
> - LAG VLAN support
> - LAG FDB support
>
> Limitations:
>
> - Only HASH lag tx type is supported
> - The Hash parameters are not configurable. They are applied
> during the LAG creation stage.
> - Enslaving a port to the LAG device that already has an
> upper device is not supported.
>
> Changes extracted from:
>
> https://lkml.org/lkml/2021/2/3/877
>
> and marked with "v2".
>
> v2:
>
> There are 2 additional preparation patches which simplifies the
> netdev topology handling.
>
> 1) Initialize 'lag' with NULL in prestera_lag_create() [suggested by Vladimir Oltean]
>
> 2) Use -ENOSPC in prestera_lag_port_add() if max lag [suggested by Vladimir Oltean]
> numbers were reached.
>
> 3) Do not propagate netdev events to prestera_switchdev [suggested by Vladimir Oltean]
> but call bridge specific funcs. It simplifies the code.
>
> 4) Check on info->link_up in prestera_netdev_port_lower_event() [suggested by Vladimir Oltean]
>
> 5) Return -EOPNOTSUPP in prestera_netdev_port_event() in case [suggested by Vladimir Oltean]
> LAG hashing mode is not supported.
>
> 6) Do not pass "lower" netdev to bridge join/leave functions. [suggested by Vladimir Oltean]
> It is not need as offloading settings applied on particular
> physical port. It requires to do extra upper dev lookup
> in case port is in the LAG which is in the bridge on vlans add/del.
>
> Serhiy Boiko (1):
> net: marvell: prestera: add LAG support
>
> Vadym Kochan (2):
> net: marvell: prestera: move netdev topology validation to
> prestera_main
> net: marvell: prestera: do not propagate netdev events to
> prestera_switchdev.c
>
> .../net/ethernet/marvell/prestera/prestera.h | 30 +-
> .../ethernet/marvell/prestera/prestera_hw.c | 180 +++++++++++-
> .../ethernet/marvell/prestera/prestera_hw.h | 14 +
> .../ethernet/marvell/prestera/prestera_main.c | 267 +++++++++++++++++-
> .../marvell/prestera/prestera_switchdev.c | 163 ++++++-----
> .../marvell/prestera/prestera_switchdev.h | 7 +-
> 6 files changed, 573 insertions(+), 88 deletions(-)
>
> --
> 2.17.1
>
next prev parent reply other threads:[~2021-06-10 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 15:43 [PATCH v2 0/3] net: marvell: prestera: add LAG support Vadym Kochan
2021-06-10 15:43 ` [PATCH v2 1/3] net: marvell: prestera: move netdev topology validation to prestera_main Vadym Kochan
2021-06-10 15:43 ` [PATCH v2 2/3] net: marvell: prestera: do not propagate netdev events to prestera_switchdev.c Vadym Kochan
2021-06-10 15:43 ` [PATCH v2 3/3] net: marvell: prestera: add LAG support Vadym Kochan
2021-06-10 22:58 ` Vladimir Oltean
2021-06-10 16:08 ` Vadym Kochan [this message]
2021-06-10 17:38 ` [PATCH v2 0/3] " Vladimir Oltean
2021-06-10 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610160828.GB29315@plvision.eu \
--to=vadym.kochan@plvision.eu \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mickeyr@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tchornyi@marvell.com \
--cc=vkochan@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox