Re: [patch V2 14/52] x86/fpu: Make copy_xstate_to_kernel() usable for [x]fpregs_get()

Borislav Petkov
2021-06-16T16:13:52Z

On Mon, Jun 14, 2021 at 05:44:22PM +0200, Thomas Gleixner wrote:
> When xsave with init state optimiziation is used then a component's state

optimization

> @@ -1062,14 +1062,20 @@ static void copy_feature(bool from_xstat
> membuf_write(to, from_xstate ? xstate : init_xstate, size);
> }
>
> -/*
> - * Convert from kernel XSAVE or XSAVES compacted format to UABI
> - * non-compacted format and copy to a kernel-space ptrace buffer.
> +/**
> + * copy_uabi_xstate_to_membuf - Copy kernel saved xstate to a UABI buffer

If this is what it does, then the function should be called:

copy_xstate_to_uabi_buf()

or so.

"membuf" is only an implementation detail anyway. IMHO.

Thx.

--
Regards/Gruss,
Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg