Re: [PATCH 2/4] fs: drop_caches: fix skipping over shadow cache inodes

Roman Gushchin
2021-06-14T22:31:33Z

On Mon, Jun 14, 2021 at 05:19:02PM -0400, Johannes Weiner wrote:
> When drop_caches truncates the page cache in an inode it also includes
> any shadow entries for evicted pages. However, there is a preliminary
> check on whether the inode has pages: if it has *only* shadow entries,
> it will skip running truncation on the inode and leave it behind.
>
> Fix the check to mapping_empty(), such that it runs truncation on any
> inode that has cache entries at all.
>
> Reported-by: Roman Gushchin <guro@fb.com>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Roman Gushchin <guro@fb.com>

Thanks!