From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Anton Blanchard <anton@ozlabs.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] trace/kprobe: Remove limit on kretprobe maxactive
Date: Tue, 15 Jun 2021 21:03:51 -0400 [thread overview]
Message-ID: <20210615210351.602bc03e@rorschach.local.home> (raw)
In-Reply-To: <20210616094622.c8bd37840898c67dddde1053@kernel.org>
On Wed, 16 Jun 2021 09:46:22 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> To avoid such trouble, I had set the 4096 limitation for the maxactive
> parameter. Of course 4096 may not enough for some use-cases. I'm welcome
> to expand it (e.g. 32k, isn't it enough?), but removing the limitation
> may cause OOM trouble easily.
What if you just made the max as 10 * number of possible cpus, or 4096,
which ever is greater? Why would a user need more?
I'd still like to get a wrapper around function graph tracing so that
kretprobes could use it. I think that would get rid of the requirement
of maxactive, because isn't that just used to have a way to know the
original return value?
-- Steve
next prev parent reply other threads:[~2021-06-16 1:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-14 18:03 [PATCH 0/2] trace/kprobe: Two fixes for kretprobes Naveen N. Rao
2021-06-14 18:03 ` [PATCH 1/2] trace/kprobe: Fix count of missed kretprobes in kprobe_profile Naveen N. Rao
2021-06-15 5:47 ` Masami Hiramatsu
2021-06-14 18:03 ` [PATCH 2/2] trace/kprobe: Remove limit on kretprobe maxactive Naveen N. Rao
2021-06-15 9:35 ` Masami Hiramatsu
2021-06-15 17:41 ` Naveen N. Rao
2021-06-16 0:46 ` Masami Hiramatsu
2021-06-16 1:03 ` Steven Rostedt [this message]
2021-06-16 2:27 ` Masami Hiramatsu
2021-06-16 15:10 ` Masami Hiramatsu
2021-06-17 16:34 ` Naveen N. Rao
2021-06-17 17:07 ` Steven Rostedt
2021-06-18 4:26 ` Masami Hiramatsu
2021-06-18 8:41 ` Naveen N. Rao
2021-06-17 16:19 ` Naveen N. Rao
2021-06-18 6:17 ` Masami Hiramatsu
2021-06-18 13:19 ` Naveen N. Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615210351.602bc03e@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=anton@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox