Re: [PATCH v4 2/7] iommu/amd: Do not use flush-queue when NpCache is on

John Garry
2021-06-21T12:43:59Z

On 16/06/2021 11:04, Nadav Amit wrote:
> - if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE))
> + if (iommu->cap & (1UL << IOMMU_CAP_NPCACHE)) {
> + if (!amd_iommu_unmap_flush)
> + pr_warn("IOMMU batching is disabled due to virtualization");

This is missing the '\n', like the Intel driver.

And, JFYI, we are also downgrading that same print to info level (in the
Intel driver).

Thanks,
John

> +
> amd_iommu_np_cache = true;
> + amd_iommu_unmap_flush = true;