From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91AEFC48BDF for ; Fri, 18 Jun 2021 14:52:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C27761260 for ; Fri, 18 Jun 2021 14:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234728AbhFROy6 (ORCPT ); Fri, 18 Jun 2021 10:54:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:44084 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234558AbhFROy4 (ORCPT ); Fri, 18 Jun 2021 10:54:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 90485610A3; Fri, 18 Jun 2021 14:52:44 +0000 (UTC) Date: Fri, 18 Jun 2021 15:52:42 +0100 From: Catalin Marinas To: Steven Price Cc: Marc Zyngier , Will Deacon , James Morse , Julien Thierry , Suzuki K Poulose , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Martin , Mark Rutland , Thomas Gleixner , qemu-devel@nongnu.org, Juan Quintela , "Dr. David Alan Gilbert" , Richard Henderson , Peter Maydell , Andrew Jones Subject: Re: [PATCH v16 7/7] KVM: arm64: Document MTE capability and ioctl Message-ID: <20210618145241.GG16116@arm.com> References: <20210618132826.54670-1-steven.price@arm.com> <20210618132826.54670-8-steven.price@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618132826.54670-8-steven.price@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 18, 2021 at 02:28:26PM +0100, Steven Price wrote: > +When this capability is enabled all memory in (non-device) memslots must not > +used VM_SHARED, attempts to create a memslot with a VM_SHARED mmap will result > +in an -EINVAL return. "must not used" doesn't sound right. Anyway, I'd remove VM_SHARED as that's a kernel internal and not something the VMM needs to be aware of. Just say something like "memslots must be mapped as shareable (MAP_SHARED)". Otherwise: Reviewed-by: Catalin Marinas