From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68821C48BDF for ; Sat, 19 Jun 2021 03:19:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EA37600CD for ; Sat, 19 Jun 2021 03:19:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235636AbhFSDWF (ORCPT ); Fri, 18 Jun 2021 23:22:05 -0400 Received: from m12-17.163.com ([220.181.12.17]:43115 "EHLO m12-17.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235603AbhFSDWD (ORCPT ); Fri, 18 Jun 2021 23:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=TiTHf 5QkrBI813AjEkIUzLOaotHjQyVGsD/vMhq6Ouk=; b=c2JNHE2Nq/BOkiiXKXUSW aH/puZNXwmq51LcDk9rBu1YuLtO4Ljw2yIl1/PfcRF5CpZVCMYFS5C+VVGLN8bUH kUwNsg3p4WnmqpuqShya7pPv2oN48LfIqNwTtFO4MmVEDlsfcy5wC2l2Zx/MX0+x 9JvtWIjJNVYd9E6+c5+V0w= Received: from localhost (unknown [218.17.89.111]) by smtp13 (Coremail) with SMTP id EcCowACnspIcYs1gZ7aE8Q--.27344S2; Sat, 19 Jun 2021 11:18:53 +0800 (CST) Date: Sat, 19 Jun 2021 11:18:52 +0800 From: Chunyou Tang To: Steven Price Cc: robh@kernel.org, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, ChunyouTang , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/panfrost:report the full raw fault information instead Message-ID: <20210619111852.00003e52@163.com> In-Reply-To: <2dcbb36a-b550-4c9d-cff8-73ca4b5abb11@arm.com> References: <20210617062054.1864-1-tangchunyou@163.com> <2dcbb36a-b550-4c9d-cff8-73ca4b5abb11@arm.com> Organization: icube X-Mailer: Claws Mail 3.10.1 (GTK+ 2.16.6; i586-pc-mingw32msvc) MIME-Version: 1.0 Content-Type: text/plain; charset=GB18030 Content-Transfer-Encoding: 8bit X-CM-TRANSID: EcCowACnspIcYs1gZ7aE8Q--.27344S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Cr1rGrW5ZryrtFW8Kr1ftFb_yoW5JF4kpr WqyFWayr92ya42va4DKa1Y9Fy3Z3W5trykGFn8Crs0vanFvF45G34vya40vr1rXr4kJay7 twsrAFW3ua1UZ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jD-B_UUUUU= X-Originating-IP: [218.17.89.111] X-CM-SenderInfo: 5wdqwu5kxq50rx6rljoofrz/1tbiHh62UVSIvTBmDwAAsf Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, 1,Now I know how to write the subject 2,the low 8 bits is the exception type in spec. and you can see prnfrost_exception_name() switch (exception_code) { /* Non-Fault Status code */ case 0x00: return "NOT_STARTED/IDLE/OK"; case 0x01: return "DONE"; case 0x02: return "INTERRUPTED"; case 0x03: return "STOPPED"; case 0x04: return "TERMINATED"; case 0x08: return "ACTIVE"; ........ ........ case 0xD8: return "ACCESS_FLAG"; case 0xD9 ... 0xDF: return "ACCESS_FLAG"; case 0xE0 ... 0xE7: return "ADDRESS_SIZE_FAULT"; case 0xE8 ... 0xEF: return "MEMORY_ATTRIBUTES_FAULT"; } return "UNKNOWN"; } the exception_code in case is only 8 bits,so if fault_status in panfrost_gpu_irq_handler() don't & 0xFF,it can't get correct exception reason,it will be always UNKNOWN. ÓÚ Fri, 18 Jun 2021 13:43:24 +0100 Steven Price дµÀ: > On 17/06/2021 07:20, ChunyouTang wrote: > > From: ChunyouTang > > > > of the low 8 bits. > > Please don't split the subject like this. The first line of the commit > should be a (very short) summary of the patch. Then a blank line and > then a longer description of what the purpose of the patch is and why > it's needed. > > Also you previously had this as part of a series (the first part > adding the "& 0xFF" in the panfrost_exception_name() call). I'm not > sure we need two patches for the single line, but as it stands this > patch doesn't apply. > > Also I'm still not receiving any emails from you directly (only via > the list), so it's possible I might have missed something you sent. > > Steve > > > > > Signed-off-by: ChunyouTang > > --- > > drivers/gpu/drm/panfrost/panfrost_gpu.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c > > b/drivers/gpu/drm/panfrost/panfrost_gpu.c index > > 1fffb6a0b24f..d2d287bbf4e7 100644 --- > > a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ > > b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -33,7 +33,7 @@ static > > irqreturn_t panfrost_gpu_irq_handler(int irq, void *data) address > > |= gpu_read(pfdev, GPU_FAULT_ADDRESS_LO); > > dev_warn(pfdev->dev, "GPU Fault 0x%08x (%s) at > > 0x%016llx\n", > > - fault_status & 0xFF, > > panfrost_exception_name(pfdev, fault_status & 0xFF), > > + fault_status, > > panfrost_exception_name(pfdev, fault_status & 0xFF), address); > > > > if (state & GPU_IRQ_MULTIPLE_FAULT) > >