From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21415C48BDF for ; Thu, 24 Jun 2021 09:23:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00C64613F6 for ; Thu, 24 Jun 2021 09:23:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231789AbhFXJZx (ORCPT ); Thu, 24 Jun 2021 05:25:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231714AbhFXJZq (ORCPT ); Thu, 24 Jun 2021 05:25:46 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DDA9C061574 for ; Thu, 24 Jun 2021 02:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1pmChoBW4Vklc89y9mnmj8rHXFIWoQLJkt3ISHBJjPA=; b=cIrdSflpgvObNOuPNkvvmSK2X 92wv8VMyb5eWMdC/0+q3TOemrhNqoPa5ftWcYAT6XL4EGYAzQaXjPJgIcgFbR8Zr3umsGAle5yu9G hFEkkwM/6XyfVoMETvuXpmfJ9A+uqhd9p5BDiuMXj6/S4tm4VWdh6IaY1T6NWQ+G034LIlesfkHoQ 4vFVdzZmIWGfCv2aqC5QUoC1UwvopTjGPHW8mC0eALU/Y1Kf5be5X+xQwI5VfyKVMhRrx0LoAKptg ey0e6i/sOKwPD4Lb7PcsPEztX7+tlLDTLtWeYQrQlnnd8sq4znld5HBqiY4Ld3IIRiYTgp9pnokA+ 2ePNgP5Yw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45300) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lwLa1-0007U1-1E; Thu, 24 Jun 2021 10:23:25 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lwLZz-0005b3-V1; Thu, 24 Jun 2021 10:23:23 +0100 Date: Thu, 24 Jun 2021 10:23:23 +0100 From: "Russell King (Oracle)" To: Tang Bin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: bL_switcher: use IS_ERR_OR_NULL() to simplify code Message-ID: <20210624092323.GP22278@shell.armlinux.org.uk> References: <20210624074223.11372-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210624074223.11372-1-tangbin@cmss.chinamobile.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 24, 2021 at 03:42:23PM +0800, Tang Bin wrote: > diff --git a/arch/arm/common/bL_switcher.c b/arch/arm/common/bL_switcher.c > index 9a9aa5354..b8e8e2567 100644 > --- a/arch/arm/common/bL_switcher.c > +++ b/arch/arm/common/bL_switcher.c > @@ -352,11 +352,9 @@ int bL_switch_request_cb(unsigned int cpu, unsigned int new_cluster_id, > > t = &bL_threads[cpu]; > > - if (IS_ERR(t->task)) > - return PTR_ERR(t->task); > - if (!t->task) > - return -ESRCH; > - > + if (IS_ERR_OR_NULL(t->task)) > + return t->task ? PTR_ERR(t->task) : -ESRCH; > + > spin_lock(&t->lock); > if (t->completer) { > spin_unlock(&t->lock); I don't think this improves the code. The original is more readable, and readability is what we care about rather than code compactness. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!