From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-24.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04219C49EA7 for ; Fri, 25 Jun 2021 15:34:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB3CA6193F for ; Fri, 25 Jun 2021 15:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbhFYPgl (ORCPT ); Fri, 25 Jun 2021 11:36:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49456 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229630AbhFYPgk (ORCPT ); Fri, 25 Jun 2021 11:36:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624635259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=P+irYxL4B6g9k/ospIqhO666waG3AOzkyA4aW0tTUSw=; b=SAgms8taLPWzj1BFpOP9+aoC4srI/l1/O+HbL/1N+kYrJhD/ha69l9DRjeHyBlFh6uus+z mLr1hDw8ZSWYSnua1FR1HJrpGbhXtrliWtoVIBZgx0T6JUKuDQcQYzvsvTfcxBEBDzsvL5 o2SNxLpIOB8Wpr2NGgQ0A/vrMhXdIt8= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-536-IaAXWq_PNICw0ds0s6ChuQ-1; Fri, 25 Jun 2021 11:34:18 -0400 X-MC-Unique: IaAXWq_PNICw0ds0s6ChuQ-1 Received: by mail-io1-f72.google.com with SMTP id 199-20020a6b01d00000b02904ed600252a1so5418430iob.15 for ; Fri, 25 Jun 2021 08:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P+irYxL4B6g9k/ospIqhO666waG3AOzkyA4aW0tTUSw=; b=p57OkzSqw3V8M1JVB4Tm7DgBt4SieJZbhxgOA//ToSkxpUs52vtz4FEXn8D7DX84Us nmEzgC6X5Fu8nhA50UTpkeN4LO9cC/ECsCVoMZsCg3iwTnB0HNRMgIvUE3D4eo4ESZ5t tAvDDgVUiI5JeYkYdWNMcoF57N89DknqOT4A0/gvAmx8N6jVcKZAoq3Wf7BxI1EBD0xT 35hEwFa59l11ZgpGTwXYOicjx90v3bj6ID11Tkc8y2CIY591VvDKh/b9bhmkKT1gbqFf t0jw72OawO1vNF1fVcW2ZUU1MCrU44n/TXTTJJA+lZMxqk1/Kj3u0oXehex+ZoyNZxzD uA+w== X-Gm-Message-State: AOAM5305WrTeKJhuT4sWCwkftK15ScQA0gJZ4bFEreSJtx+YbtOquZfG bQU2WRNdVqtSDfVkTB0gXwmHuCk4Z7q/u8mSf6XCpm47QOgggoYO7bVpVcUU5AzFLJbBxig03kU 1c8ZoIMJzoIifgKE+0rGwaI/gxr3jMsaay/pjOoFvUz6y9xQgoDIbBA/t9b8q328/8CAeuRnEuw == X-Received: by 2002:a6b:6205:: with SMTP id f5mr9020432iog.60.1624635255506; Fri, 25 Jun 2021 08:34:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz6tjZFUGP/NqbgvCCXLVIQHOsoTMddP4SdvnmyH8q0xAkmsSrB5eK5GxDG+LLmaPOasLYXpw== X-Received: by 2002:a6b:6205:: with SMTP id f5mr9020417iog.60.1624635255257; Fri, 25 Jun 2021 08:34:15 -0700 (PDT) Received: from t490s.redhat.com (bras-base-toroon474qw-grc-65-184-144-111-238.dsl.bell.ca. [184.144.111.238]) by smtp.gmail.com with ESMTPSA id l12sm3679281iln.20.2021.06.25.08.34.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jun 2021 08:34:14 -0700 (PDT) From: Peter Xu To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: peterx@redhat.com, Maxim Levitsky , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini Subject: [PATCH v2 7/9] KVM: X86: MMU: Tune PTE_LIST_EXT to be bigger Date: Fri, 25 Jun 2021 11:34:13 -0400 Message-Id: <20210625153413.43570-1-peterx@redhat.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210625153214.43106-1-peterx@redhat.com> References: <20210625153214.43106-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently rmap array element only contains 3 entries. However for EPT=N there could have a lot of guest pages that got tens of even hundreds of rmap entry. A normal distribution of a 6G guest (even if idle) shows this with rmap count statistics: Rmap_Count: 0 1 2-3 4-7 8-15 16-31 32-63 64-127 128-255 256-511 512-1023 Level=4K: 3089171 49005 14016 1363 235 212 15 7 0 0 0 Level=2M: 5951 227 0 0 0 0 0 0 0 0 0 Level=1G: 32 0 0 0 0 0 0 0 0 0 0 If we do some more fork some pages will grow even larger rmap counts. This patch makes PTE_LIST_EXT bigger so it'll be more efficient for the general use case of EPT=N as we do list reference less and the loops over PTE_LIST_EXT will be slightly more efficient; but still not too large so less waste when array not full. It should not affecting EPT=Y since EPT normally only has zero or one rmap entry for each page, so no array is even allocated. With a test case to fork 500 child and recycle them ("./rmap_fork 500" [1]), this patch speeds up fork time of about 22%. Before: 367.20 (+-4.58%) After: 302.00 (+-5.30%) [1] https://github.com/xzpeter/clibs/commit/825436f825453de2ea5aaee4bdb1c92281efe5b3 Signed-off-by: Peter Xu --- arch/x86/kvm/mmu/mmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index b3f738a7c05e..9b093985a2ef 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -137,8 +137,8 @@ module_param(dbg, bool, 0644); #include -/* make pte_list_desc fit well in cache line */ -#define PTE_LIST_EXT 3 +/* make pte_list_desc fit well in cache lines */ +#define PTE_LIST_EXT 15 struct pte_list_desc { u64 *sptes[PTE_LIST_EXT]; -- 2.31.1