The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Daniel Wagner <dwagner@suse.de>
To: John Kacur <jkacur@redhat.com>
Cc: Daniel Wagner <wagi@monom.org>, Mike Galbraith <efault@gmx.de>,
	RT <linux-rt-users@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Clark Williams <williams@redhat.com>,
	Johnathan Schwender <schwenderjonathan@gmail.com>,
	Peter Xu <peterx@redhat.com>
Subject: Re: [ANNOUNCE] rt-tests-2.0
Date: Mon, 28 Jun 2021 16:13:13 +0200	[thread overview]
Message-ID: <20210628141313.3fixpscbdc4ugnld@beryllium.lan> (raw)
In-Reply-To: <f31d9d37-df6d-90b0-8bf9-95156c27e8d@redhat.com>

On Mon, Jun 28, 2021 at 09:50:25AM -0400, John Kacur wrote:
> > I'd say the tsbuf access is the one which triggers a pagefault.
> > 
> > John, I would suggest to move the rt_test_start() into rt_init() and
> > take the timestamp at the execution start (as my initial version was). I
> > think the additional pain in slightly more correct start timestamp
> > (which is also not defined what it actually means in this context) is
> > just not worth the effort.
> > 
> > Thanks,
> > Daniel
> > 
> 
> Send me a patch, and I'll have a look. The timerthread()function is
> sensitive anyway, so it's probably a good idea not to put that kind
> of thing there.
> 
> Note that the the code following the /* Get Current Time */
> is getting the time, but you probably want something rougher that
> you can call strftime on?

I think it's just the buffer strftime is writting into it. The page is
probably not mapped and hence the pagefault in the first access.

Anyway, I'll send a patch which moves the rt_test_start() into rt_init().

      reply	other threads:[~2021-06-28 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25 16:08 [ANNOUNCE] rt-tests-2.0 John Kacur
2021-06-26  6:55 ` Mike Galbraith
2021-06-26 11:47   ` Mike Galbraith
2021-06-26 12:45     ` Mike Galbraith
2021-06-28  8:11       ` Daniel Wagner
2021-06-28 13:50         ` John Kacur
2021-06-28 14:13           ` Daniel Wagner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210628141313.3fixpscbdc4ugnld@beryllium.lan \
    --to=dwagner@suse.de \
    --cc=efault@gmx.de \
    --cc=jkacur@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=peterx@redhat.com \
    --cc=schwenderjonathan@gmail.com \
    --cc=wagi@monom.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox