From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3B93C11F66 for ; Tue, 29 Jun 2021 14:03:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB01361DB4 for ; Tue, 29 Jun 2021 14:03:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231332AbhF2OFo (ORCPT ); Tue, 29 Jun 2021 10:05:44 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]:59317 "EHLO mail-0201.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229510AbhF2OFl (ORCPT ); Tue, 29 Jun 2021 10:05:41 -0400 Date: Tue, 29 Jun 2021 14:02:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bryanbrattlof.com; s=protonmail3; t=1624975387; bh=dhxJvVB5vGNzlqPV/Vc3Rg4M/zVZQZH9g1DDMaRrUrA=; h=Date:To:From:Cc:Reply-To:Subject:From; b=KSVz05mJvt0ba3Z0Sx3q3DIsp4kxnQPzoEMk+PV3n2oEog69PWwryma+ECfzD5aNE 4VxxGpMeGoIgdi8+qUrBRPOQovl2APsizUywx+mIjEycsyKx4FY8zUawO21evHk77X 3fw7eCmyaln4Tuba1vqExm4aXsGE+E1h2//p/YCyku6MfuK2f9+HuYyEfF8tswUZkb gt86GjccCN9JCT7+TP38ZVN9K2TjPi9P8u5XBVJP+Zh3cezMy5Z+SGSM39POGXlmEy hIVziKAQZKmDJlyiFCltdMkt+0H2E6FyFctZEnCuU5cvNKgww0UlMNDgpwPCbn9AAe YdQwqK+oOt4AA== To: Greg Kroah-Hartman From: Bryan Brattlof Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Bryan Brattlof Reply-To: Bryan Brattlof Subject: [PATCH] staging: rtl8723bs: remove custom endian conversion macros Message-ID: <20210629135824.47749-1-hello@bryanbrattlof.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The rtw_cpu_to_leXX() and rtw_leXX_to_cpu() family of macros are unnecessary and should be removed. Signed-off-by: Bryan Brattlof --- drivers/staging/rtl8723bs/core/rtw_io.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8= 723bs/core/rtw_io.c index 856e23398c03..4d3c30ec93b5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_io.c +++ b/drivers/staging/rtl8723bs/core/rtw_io.c @@ -28,11 +28,6 @@ jackson@realtek.com.tw #include #include -#define rtw_le16_to_cpu(val)=09=09val -#define rtw_le32_to_cpu(val)=09=09val -#define rtw_cpu_to_le16(val)=09=09val -#define rtw_cpu_to_le32(val)=09=09val - u8 rtw_read8(struct adapter *adapter, u32 addr) { =09/* struct=09io_queue=09*pio_queue =3D (struct io_queue *)adapter->pio_q= ueue; */ @@ -47,7 +42,6 @@ u8 rtw_read8(struct adapter *adapter, u32 addr) u16 rtw_read16(struct adapter *adapter, u32 addr) { -=09u16 r_val; =09/* struct=09io_queue=09*pio_queue =3D (struct io_queue *)adapter->pio_q= ueue; */ =09struct io_priv *pio_priv =3D &adapter->iopriv; =09struct=09intf_hdl=09=09*pintfhdl =3D &(pio_priv->intf); @@ -55,13 +49,11 @@ u16 rtw_read16(struct adapter *adapter, u32 addr) =09_read16 =3D pintfhdl->io_ops._read16; -=09r_val =3D _read16(pintfhdl, addr); -=09return rtw_le16_to_cpu(r_val); +=09return _read16(pintfhdl, addr); } u32 rtw_read32(struct adapter *adapter, u32 addr) { -=09u32 r_val; =09/* struct=09io_queue=09*pio_queue =3D (struct io_queue *)adapter->pio_q= ueue; */ =09struct io_priv *pio_priv =3D &adapter->iopriv; =09struct=09intf_hdl=09=09*pintfhdl =3D &(pio_priv->intf); @@ -69,8 +61,7 @@ u32 rtw_read32(struct adapter *adapter, u32 addr) =09_read32 =3D pintfhdl->io_ops._read32; -=09r_val =3D _read32(pintfhdl, addr); -=09return rtw_le32_to_cpu(r_val); +=09return _read32(pintfhdl, addr); } -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16EC8C11F66 for ; Tue, 29 Jun 2021 14:05:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EBE3A61DB4 for ; Tue, 29 Jun 2021 14:05:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232579AbhF2OHr (ORCPT ); Tue, 29 Jun 2021 10:07:47 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]:48972 "EHLO mail-0201.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229990AbhF2OHo (ORCPT ); Tue, 29 Jun 2021 10:07:44 -0400 Date: Tue, 29 Jun 2021 14:04:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bryanbrattlof.com; s=protonmail3; t=1624975484; bh=dhxJvVB5vGNzlqPV/Vc3Rg4M/zVZQZH9g1DDMaRrUrA=; h=Date:To:From:Cc:Reply-To:Subject:From; b=XlecZXxI6Xfp+NGBpyfOcyE8lxYK3caHy5ZTXxrL0ZhsnJpmBb4JGOmP/laKSzayw 1yZ2+W1n6SA5scwQPvUzMI1e5m/mShEOUCH18JUYaHh7FUmOMrYnQsjc3HugiJohUS a8u7tFPZDRCzbXf5OldIMaGdSWcFF0D+CgeF4awELG0C8KWj3A8p5f/qCfIxWFQ3TA xzCrRIIa0iPx0ldIFrghx64F8MscvcSAhh3Of+5U0JcQj6QOckQ7ubi/gPBfRh6gxs 8B9IurABu/mQ9oUcyugWJlASsoELeDM8CjcW4gF0Fpq7YBr4Z3cE4C+D/AJcdVX8jt OId6IAe+6YRJw== To: Greg Kroah-Hartman From: Bryan Brattlof Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Bryan Brattlof Reply-To: Bryan Brattlof Subject: [PATCH] staging: rtl8723bs: remove custom endian conversion macros Message-ID: <20210629135824.47749-1-hello@bryanbrattlof.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20210629140438.vn2juAWW-gVOo5AAzk3-z-eUZ0S8wJdCByJH4mTGQTY@z> The rtw_cpu_to_leXX() and rtw_leXX_to_cpu() family of macros are unnecessary and should be removed. Signed-off-by: Bryan Brattlof --- drivers/staging/rtl8723bs/core/rtw_io.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8= 723bs/core/rtw_io.c index 856e23398c03..4d3c30ec93b5 100644 --- a/drivers/staging/rtl8723bs/core/rtw_io.c +++ b/drivers/staging/rtl8723bs/core/rtw_io.c @@ -28,11 +28,6 @@ jackson@realtek.com.tw #include #include -#define rtw_le16_to_cpu(val)=09=09val -#define rtw_le32_to_cpu(val)=09=09val -#define rtw_cpu_to_le16(val)=09=09val -#define rtw_cpu_to_le32(val)=09=09val - u8 rtw_read8(struct adapter *adapter, u32 addr) { =09/* struct=09io_queue=09*pio_queue =3D (struct io_queue *)adapter->pio_q= ueue; */ @@ -47,7 +42,6 @@ u8 rtw_read8(struct adapter *adapter, u32 addr) u16 rtw_read16(struct adapter *adapter, u32 addr) { -=09u16 r_val; =09/* struct=09io_queue=09*pio_queue =3D (struct io_queue *)adapter->pio_q= ueue; */ =09struct io_priv *pio_priv =3D &adapter->iopriv; =09struct=09intf_hdl=09=09*pintfhdl =3D &(pio_priv->intf); @@ -55,13 +49,11 @@ u16 rtw_read16(struct adapter *adapter, u32 addr) =09_read16 =3D pintfhdl->io_ops._read16; -=09r_val =3D _read16(pintfhdl, addr); -=09return rtw_le16_to_cpu(r_val); +=09return _read16(pintfhdl, addr); } u32 rtw_read32(struct adapter *adapter, u32 addr) { -=09u32 r_val; =09/* struct=09io_queue=09*pio_queue =3D (struct io_queue *)adapter->pio_q= ueue; */ =09struct io_priv *pio_priv =3D &adapter->iopriv; =09struct=09intf_hdl=09=09*pintfhdl =3D &(pio_priv->intf); @@ -69,8 +61,7 @@ u32 rtw_read32(struct adapter *adapter, u32 addr) =09_read32 =3D pintfhdl->io_ops._read32; -=09r_val =3D _read32(pintfhdl, addr); -=09return rtw_le32_to_cpu(r_val); +=09return _read32(pintfhdl, addr); } -- 2.27.0