From: Mian Yousaf Kaukab <ykaukab@suse.de>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>,
biwen.li@nxp.com, Bruno Thomsen <bth@kamstrup.com>
Subject: Re: [PATCH v5] rtc: pcf2127: handle timestamp interrupts
Date: Tue, 29 Jun 2021 16:52:21 +0200 [thread overview]
Message-ID: <20210629145221.GF81946@suse.de> (raw)
In-Reply-To: <CAH+2xPA+0pej3WrUmyDnCyrWy1TjN3fHrk+L4GW+JAwyEbF5XA@mail.gmail.com>
On Mon, Jun 28, 2021 at 11:42:03AM +0200, Bruno Thomsen wrote:
> Hi again,
>
> Forgot another important comment. After you moved code to
> pcf2127_rtc_ts_read() it seems to lookup pcf2127 struct wrong.
>
> struct pcf2127 *pcf2127 = dev_get_drvdata(dev->parent);
Good catch! I will fix it by calling pcf2127_rtc_ts_read(dev->parent).
dev_get_drvdata(dev) is correct from the irq path.
>
> /Bruno
>
BR,
Yousaf
next prev parent reply other threads:[~2021-06-29 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 15:22 [PATCH v5] rtc: pcf2127: handle timestamp interrupts Mian Yousaf Kaukab
2021-06-28 9:18 ` Bruno Thomsen
2021-06-28 9:42 ` Bruno Thomsen
2021-06-29 14:52 ` Mian Yousaf Kaukab [this message]
2021-06-29 14:47 ` Mian Yousaf Kaukab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210629145221.GF81946@suse.de \
--to=ykaukab@suse.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=biwen.li@nxp.com \
--cc=bruno.thomsen@gmail.com \
--cc=bth@kamstrup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox