From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51BA5C11F69 for ; Tue, 29 Jun 2021 14:52:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D2CA61D8E for ; Tue, 29 Jun 2021 14:52:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234508AbhF2Oy6 (ORCPT ); Tue, 29 Jun 2021 10:54:58 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:41340 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232521AbhF2Oyv (ORCPT ); Tue, 29 Jun 2021 10:54:51 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 64F521FD84; Tue, 29 Jun 2021 14:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624978343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R6X/pQ7cKEtlsMwepYqULQ7e+u1sBHuvidfx8sln21w=; b=E4LG94XuwCv7baeSyslniUB/7fW7SZbECqHbWoD2UDiPXRgODLn54FymdoYPTrai4Zmjzh oxgf5tkCHLHZBcue8VPxNBGqqKbcp/ptZ2i2TnQI1FhgN/96x9+Z9MjKPHydwru57Ud9o2 +gwD7C+WXn5Gn65kGEVJAP4nwgfUgCo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624978343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R6X/pQ7cKEtlsMwepYqULQ7e+u1sBHuvidfx8sln21w=; b=wPfu5FGWWN5hKwbY9JYRvwjK9UOU6iJrgw+11x1r2pMahHxulqJnuE1HRg4oT4K9FXAp+h mwRyGk5QikLQjWAQ== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 2C07E11906; Tue, 29 Jun 2021 14:52:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624978343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R6X/pQ7cKEtlsMwepYqULQ7e+u1sBHuvidfx8sln21w=; b=E4LG94XuwCv7baeSyslniUB/7fW7SZbECqHbWoD2UDiPXRgODLn54FymdoYPTrai4Zmjzh oxgf5tkCHLHZBcue8VPxNBGqqKbcp/ptZ2i2TnQI1FhgN/96x9+Z9MjKPHydwru57Ud9o2 +gwD7C+WXn5Gn65kGEVJAP4nwgfUgCo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624978343; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R6X/pQ7cKEtlsMwepYqULQ7e+u1sBHuvidfx8sln21w=; b=wPfu5FGWWN5hKwbY9JYRvwjK9UOU6iJrgw+11x1r2pMahHxulqJnuE1HRg4oT4K9FXAp+h mwRyGk5QikLQjWAQ== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id /INbCacz22APFAAALh3uQQ (envelope-from ); Tue, 29 Jun 2021 14:52:23 +0000 Date: Tue, 29 Jun 2021 16:52:21 +0200 From: Mian Yousaf Kaukab To: Bruno Thomsen Cc: Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, open list , biwen.li@nxp.com, Bruno Thomsen Subject: Re: [PATCH v5] rtc: pcf2127: handle timestamp interrupts Message-ID: <20210629145221.GF81946@suse.de> References: <20210624152241.4476-1-ykaukab@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 28, 2021 at 11:42:03AM +0200, Bruno Thomsen wrote: > Hi again, > > Forgot another important comment. After you moved code to > pcf2127_rtc_ts_read() it seems to lookup pcf2127 struct wrong. > > struct pcf2127 *pcf2127 = dev_get_drvdata(dev->parent); Good catch! I will fix it by calling pcf2127_rtc_ts_read(dev->parent). dev_get_drvdata(dev) is correct from the irq path. > > /Bruno > BR, Yousaf