From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CCA13C11F66
	for <linux-kernel@archiver.kernel.org>; Tue, 29 Jun 2021 13:32:43 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id A514161D8E
	for <linux-kernel@archiver.kernel.org>; Tue, 29 Jun 2021 13:32:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233901AbhF2NfI (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 29 Jun 2021 09:35:08 -0400
Received: from mail.kernel.org ([198.145.29.99]:56110 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233665AbhF2Nex (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 29 Jun 2021 09:34:53 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2780C61D4D;
        Tue, 29 Jun 2021 13:32:22 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1624973546;
        bh=N5nKZVhyVnaXFO9+amiH8e/fbL4qqMXzYfOv0Kle2zE=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=eVP7SmWCkWzDclN1i8ksCFuxBtjFOEqTGF51EEW8UVNImYHbhS//oBYnmqtviOHJ/
         /1tWsd9FG8UlSlOi48GENozjsYxriURvrCjaxFYU+NjwC+E4uT9mICxEl/Lbyw7joj
         lZeh7hu24NZAQTUBCAV8L83tQZEUG+AUJ+OsLl5dgaxfRSzh1jrBwOI83ugSVIkTBp
         5RDRi9qZEw0twKcHfMzslO14t6hrn93z/HDj607kTvBoKrObYyBd5DCEch3OOFb6zm
         DedgGmwp9UFymfXgaYbc6Q1063ETsm/i3SafneAqL24zPQuRP+ESzwsb6PBU9XvI2c
         r7yoDMcjb74SA==
Date:   Tue, 29 Jun 2021 15:32:20 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To:     Axel Lin <axel.lin@ingics.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linuxarm@huawei.com, mauro.chehab@huawei.com,
        Lee Jones <lee.jones@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-staging@lists.linux.dev
Subject: Re: [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform
 drvdata
Message-ID: <20210629153220.52fffece@coco.lan>
In-Reply-To: <CAFRkauCPKQyD_Dooqrxvra94RyLXrPDeCSSdfBfvh-o0Zh8q3g@mail.gmail.com>
References: <cover.1624962269.git.mchehab+huawei@kernel.org>
        <eed34e8897c79a2ab13573d3da12c86569bca0f6.1624962269.git.mchehab+huawei@kernel.org>
        <CAFRkauCzHqUfva+zTRhOyiMMb4WsKPHvYJuqpOPwy+siPMZGOQ@mail.gmail.com>
        <20210629130957.484f5c43@coco.lan>
        <CAFRkauCPKQyD_Dooqrxvra94RyLXrPDeCSSdfBfvh-o0Zh8q3g@mail.gmail.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, 29 Jun 2021 20:51:01 +0800
Axel Lin <axel.lin@ingics.com> escreveu:

> > If you're in doubt, try to apply this series, and then change the
> > driver again to use platform data. You'll see that it will stop
> > booting after initializing the first regulator.
> >  
> 
> Sorry I don't have this h/w to test.

Then, why do you care? Your patch broke the driver. Changes like
that should be tested on a real hardware, in order to avoid
regressions.

Thanks,
Mauro