Re: [PATCH v7 20/37] mmc: sdhci-tegra: Add runtime PM and OPP support

kernel test robot
2021-07-02T03:40:13Z

[-- Attachment #1: Type: text/plain, Size: 4243 bytes --]

Hi Dmitry,

I love your patch! Yet something to improve:

[auto build test ERROR on next-20210701]
[cannot apply to tegra/for-next robh/for-next tegra-drm/drm/tegra/for-next v5.13 v5.13-rc7 v5.13-rc6 v5.13]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/NVIDIA-Tegra-power-management-patches-for-5-15/20210702-073048
base: fb0ca446157a86b75502c1636b0d81e642fe6bf1
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/bd90f252831cdc7191a0fef94041489c066e286a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Dmitry-Osipenko/NVIDIA-Tegra-power-management-patches-for-5-15/20210702-073048
git checkout bd90f252831cdc7191a0fef94041489c066e286a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/mmc/host/sdhci-tegra.c: In function 'sdhci_tegra_suspend':
>> drivers/mmc/host/sdhci-tegra.c:1813:8: error: implicit declaration of function 'sdhci_suspend_host'; did you mean 'sdhci_add_host'? [-Werror=implicit-function-declaration]
1813 | ret = sdhci_suspend_host(host);
| ^~~~~~~~~~~~~~~~~~
| sdhci_add_host
>> drivers/mmc/host/sdhci-tegra.c:1821:3: error: implicit declaration of function 'sdhci_resume_host'; did you mean 'sdhci_remove_host'? [-Werror=implicit-function-declaration]
1821 | sdhci_resume_host(host);
| ^~~~~~~~~~~~~~~~~
| sdhci_remove_host
cc1: some warnings being treated as errors

vim +1813 drivers/mmc/host/sdhci-tegra.c

bd90f252831cdc Dmitry Osipenko 2021-07-02 1801
bd90f252831cdc Dmitry Osipenko 2021-07-02 1802 static int __maybe_unused sdhci_tegra_suspend(struct device *dev)
bd90f252831cdc Dmitry Osipenko 2021-07-02 1803 {
bd90f252831cdc Dmitry Osipenko 2021-07-02 1804 struct sdhci_host *host = dev_get_drvdata(dev);
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1805 int ret;
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1806
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1807 if (host->mmc->caps2 & MMC_CAP2_CQE) {
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1808 ret = cqhci_suspend(host->mmc);
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1809 if (ret)
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1810 return ret;
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1811 }
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1812
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 @1813 ret = sdhci_suspend_host(host);
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1814 if (ret) {
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1815 cqhci_resume(host->mmc);
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1816 return ret;
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1817 }
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1818
bd90f252831cdc Dmitry Osipenko 2021-07-02 1819 ret = pm_runtime_force_suspend(dev);
bd90f252831cdc Dmitry Osipenko 2021-07-02 1820 if (ret) {
bd90f252831cdc Dmitry Osipenko 2021-07-02 @1821 sdhci_resume_host(host);
bd90f252831cdc Dmitry Osipenko 2021-07-02 1822 cqhci_resume(host->mmc);
bd90f252831cdc Dmitry Osipenko 2021-07-02 1823 return ret;
bd90f252831cdc Dmitry Osipenko 2021-07-02 1824 }
bd90f252831cdc Dmitry Osipenko 2021-07-02 1825
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1826 return 0;
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1827 }
71c733c4e1aeb8 Sowjanya Komatineni 2019-04-11 1828

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60867 bytes --]