Re: [PATCH 0/4] FPGA Manager address unused variable warnings

Tom Rix
2021-07-06T16:28:44Z

On 7/1/21 8:54 PM, Moritz Fischer wrote:
> This patchset addresses a handful of warnings as result of_match_ids
> being not properly wrapped in #ifdef CONFIG_OF.
>
> Moritz Fischer (4):
> fpga: altera-freeze-bridge: Address warning about unused variable
> fpga: xiilnx-spi: Address warning about unused variable
> fpga: xilinx-pr-decoupler: Address warning about unused variable
> fpga: zynqmp-fpga: Address warning about unused variable
>
> drivers/fpga/altera-freeze-bridge.c | 2 ++
> drivers/fpga/xilinx-pr-decoupler.c | 2 ++
> drivers/fpga/xilinx-spi.c | 2 ++
> drivers/fpga/zynqmp-fpga.c | 3 ++-
> 4 files changed, 8 insertions(+), 1 deletion(-)

I am not seeing these warnings, but it is still worth doing.

I think a few more files need this change.

altera-ps-spi.c, dfl-n3000-nios.c, altera-hps2fpga.c, stratix10-soc.c,
socfpga-a10.c, altera-fpga2sdram.c

Not needed for

altera-pr-ip-core-plat.c and ice40-spi.c

These have depends on OF in Kconfig.

Tom