* [PATCH v1] regulator: tps65910: Silence deferred probe error
@ 2021-07-05 20:12 Dmitry Osipenko
2021-07-12 10:45 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Osipenko @ 2021-07-05 20:12 UTC (permalink / raw)
To: Matt Merhar, Mark Brown, Liam Girdwood; +Cc: linux-kernel
The TPS65910 regulator now gets a deferred probe until supply regulator is
registered. Silence noisy error message about the deferred probe.
Fixes: aea6cb99703e ("regulator: resolve supply after creating regulator")
Reported-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
Tested-by: Matt Merhar <mattmerhar@protonmail.com> # Ouya T30
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/regulator/tps65910-regulator.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 1d5b0a1b86f7..06cbe60c990f 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -1211,12 +1211,10 @@ static int tps65910_probe(struct platform_device *pdev)
rdev = devm_regulator_register(&pdev->dev, &pmic->desc[i],
&config);
- if (IS_ERR(rdev)) {
- dev_err(tps65910->dev,
- "failed to register %s regulator\n",
- pdev->name);
- return PTR_ERR(rdev);
- }
+ if (IS_ERR(rdev))
+ return dev_err_probe(tps65910->dev, PTR_ERR(rdev),
+ "failed to register %s regulator\n",
+ pdev->name);
/* Save regulator for cleanup */
pmic->rdev[i] = rdev;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] regulator: tps65910: Silence deferred probe error
2021-07-05 20:12 [PATCH v1] regulator: tps65910: Silence deferred probe error Dmitry Osipenko
@ 2021-07-12 10:45 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-07-12 10:45 UTC (permalink / raw)
To: Matt Merhar, Dmitry Osipenko, Liam Girdwood; +Cc: Mark Brown, linux-kernel
On Mon, 5 Jul 2021 23:12:11 +0300, Dmitry Osipenko wrote:
> The TPS65910 regulator now gets a deferred probe until supply regulator is
> registered. Silence noisy error message about the deferred probe.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/1] regulator: tps65910: Silence deferred probe error
commit: e301df76472cc929fa62d923bc3892931f7ad71d
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-12 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-07-05 20:12 [PATCH v1] regulator: tps65910: Silence deferred probe error Dmitry Osipenko
2021-07-12 10:45 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox