Re: [gustavoars-linux:for-next/kspp 5/5] kernel/debug/gdbstub.c:1049:4: warning: fallthrough annotation in unreachable code

Andy Shevchenko
2021-07-12T11:23:12Z

On Mon, Jul 12, 2021 at 2:11 PM kernel test robot <lkp@intel.com> wrote:

> All warnings (new ones prefixed by >>):
>
> >> kernel/debug/gdbstub.c:1049:4: warning: fallthrough annotation in unreachable code [-Wimplicit-fallthrough]
> fallthrough;
> ^
> include/linux/compiler_attributes.h:210:41: note: expanded from macro 'fallthrough'
> # define fallthrough __attribute__((__fallthrough__))
> ^
> 1 warning generated.

> 53197fc4954924 Jason Wessel 2010-04-02 1039 case 'Z': /* Break point set */
> 53197fc4954924 Jason Wessel 2010-04-02 1040 gdb_cmd_break(ks);
> 53197fc4954924 Jason Wessel 2010-04-02 1041 break;
> dcc7871128e994 Jason Wessel 2010-05-20 1042 #ifdef CONFIG_KGDB_KDB
> dcc7871128e994 Jason Wessel 2010-05-20 1043 case '3': /* Escape into back into kdb */
> dcc7871128e994 Jason Wessel 2010-05-20 1044 if (remcom_in_buffer[1] == '\0') {
> dcc7871128e994 Jason Wessel 2010-05-20 1045 gdb_cmd_detachkill(ks);
> dcc7871128e994 Jason Wessel 2010-05-20 1046 return DBG_PASS_EVENT;
> dcc7871128e994 Jason Wessel 2010-05-20 1047 }
> dcc7871128e994 Jason Wessel 2010-05-20 1048 #endif
> df561f6688fef7 Gustavo A. R. Silva 2020-08-23 @1049 fallthrough;

Obviously this should be inside ifdeffery. Easy to fix cases.

--
With Best Regards,
Andy Shevchenko