From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56126C11F66 for ; Tue, 13 Jul 2021 06:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3CB7261260 for ; Tue, 13 Jul 2021 06:03:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233374AbhGMGGc (ORCPT ); Tue, 13 Jul 2021 02:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231261AbhGMGGa (ORCPT ); Tue, 13 Jul 2021 02:06:30 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 319D9C0613E9 for ; Mon, 12 Jul 2021 23:03:41 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id j199so18586326pfd.7 for ; Mon, 12 Jul 2021 23:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FB5vlvnYYvrU21B0CO4PGpbTyzy5lXFnKOJGx4/Q5XE=; b=H4eCa4SvuHL/QWjRdLmS+gv2GALPuJmxIAHxiRqfZdnVu6of/q5Co0QFLNCiInuu1k LUirhDbKxTne3QHePIiEfmQ77whgezOlJ8Nwelh11uNtXr2Pk2A3x0jt0Ven/CSYeQqM Ds24EAskBKW8wcANZhwqsBkrWJIP9lcJiuGn/j6UdIDP7OottKITrU8q8dAiWSy74/+b eyTi2D5XOH5KY5XmzsmFnftZixqqDxFQOIT3DBwkEIXh4YcurcRGQqUOW8UAYiQJiEkt cPgfcyi/HFc+oVcbfXjAeOVL1z6mWhweZuNbrpiV2UizV88hZKSX+Xv4EWVho1gOBUj9 EcnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FB5vlvnYYvrU21B0CO4PGpbTyzy5lXFnKOJGx4/Q5XE=; b=TW5jW1bX1eeddjPEOM68/ZHpWW6zaTUgShTUrL90Dq/hiCbgKoZxWD5LPyKeDQu1B+ UmezCfAn1fWL8K0whHFHpcWY3QojCRsV2aK/D8PlSDj10H1L6L9faMxU16PHCOrLGoX9 iZSrC+m7sOujNBQ3N2FhX1A+wPC9OEdlgNdS9h5oVsQAuCfUr1hFimOXPYMyLy/x/A/F D69I/Lfnn5d3WXMgpwEnKZ2zbPfqwqbWj6VxVXE/hfN1kIPWQfez/mOEntkLpQA4IusK t3dejHvcwVDn+KzANQv0m2SV3KIit427i77PTxkC8EONibrfwD/ZSeKu7vLaBMKee9u4 jB0w== X-Gm-Message-State: AOAM533kov/t6v92JFvorRUdkIqkIqNtUyPr1tWYC8XA3n+xdiUUuajX hIqQfBNqxXmvM2/puqoKAAg86Q== X-Google-Smtp-Source: ABdhPJw2WQAbtFk5/oGiEfXgsdAIOhd7cw/6gmLcg2Wkdqol49gEbGfNEypCUC8rP0zYXi+GhAGHkQ== X-Received: by 2002:aa7:8218:0:b029:316:88e:2a3a with SMTP id k24-20020aa782180000b0290316088e2a3amr2814735pfi.16.1626156220600; Mon, 12 Jul 2021 23:03:40 -0700 (PDT) Received: from x1 ([174.127.163.79]) by smtp.gmail.com with ESMTPSA id n6sm12039049pgb.60.2021.07.12.23.03.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jul 2021 23:03:39 -0700 (PDT) Date: Mon, 12 Jul 2021 23:03:38 -0700 From: Drew Fustini To: Geert Uytterhoeven Cc: Rob Herring , Paul Walmsley , Palmer Dabbelt , Michael Zhu , Wei Fu , Jack Zhu , Leyfoon Tan , Emil Renner Berthing , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-riscv , Linux Kernel Mailing List Subject: Re: [PATCH v3] dt-bindings: riscv: add starfive jh7100 bindings Message-ID: <20210713060338.GA2992629@x1> References: <20210709201603.2625664-1-drew@beagleboard.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 12, 2021 at 01:24:19PM +0200, Geert Uytterhoeven wrote: > Hi Drew, > > On Fri, Jul 9, 2021 at 10:17 PM Drew Fustini wrote: > > Add DT binding documentation for the StarFive JH7100 Soc [1] and the > > BeagleV Starlight JH7100 board [2]. > > > > [1] https://github.com/starfive-tech/beaglev_doc > > [2] https://github.com/beagleboard/beaglev-starlight > > > > Signed-off-by: Drew Fustini > > --- > > v3 changes: > > - added revision number for the board and soc after question from Palmer > > Thanks for the update! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > @@ -0,0 +1,27 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/riscv/starfive.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: StarFive SoC-based boards > > + > > +maintainers: > > + - Michael Zhu > > + - Drew Fustini > > + > > +description: > > + StarFive SoC-based boards > > + > > +properties: > > + $nodename: > > + const: '/' > > + compatible: > > + oneOf: > > + - items: > > + - const: beagle,beaglev-starlight-jh7100-r0 > > + - const: starfive,jh7100-r0 > > While I can be convinced about the board revision number (probably you > know better if there will be different board revisions that matter), > I'm wondering if the revision number makes sense for the SoC part. > Will there be a new revision of jh7100, or will the next revision > be jh7110, which will use a different compatible value anyway? > Is there an on-chip register that allows the kernel to find out the > revision info? Might be better to use that with soc_device_register() > and soc_device_match() We do anticipate making additional BeagleV Starlight boards with the JH7100 SoC and those new boards may need to have a different USB hub chip due to sourcing. Thus it is possible that there will be a r1 board in the future. However, I think you are correct about the SoC. There won't be any new revisions of the JH7100 SoC. All chips with that part number will have the same design. There will eventually be JH7110 which is a different design but I did not want to prematurely add a compatible for that. Thanks, Drew