From: Peter Zijlstra <peterz@infradead.org>
To: Wei Liu <wei.liu@kernel.org>
Cc: Ani Sinha <ani@anisinha.ca>,
linux-kernel@vger.kernel.org, anirban.sinha@nokia.com,
mikelley@microsoft.com, "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Dexuan Cui <decui@microsoft.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-hyperv@vger.kernel.org
Subject: Re: [PATCH] Hyper-V: fix for unwanted manipulation of sched_clock when TSC marked unstable
Date: Tue, 13 Jul 2021 15:17:56 +0200 [thread overview]
Message-ID: <20210713131756.GD4170@worktop.programming.kicks-ass.net> (raw)
In-Reply-To: <20210713130446.gt7k3cwlmhsxtltw@liuwe-devbox-debian-v2>
On Tue, Jul 13, 2021 at 01:04:46PM +0000, Wei Liu wrote:
> On Tue, Jul 13, 2021 at 08:35:21AM +0530, Ani Sinha wrote:
> > Marking TSC as unstable has a side effect of marking sched_clock as
> > unstable when TSC is still being used as the sched_clock. This is not
> > desirable. Hyper-V ultimately uses a paravirtualized clock source that
> > provides a stable scheduler clock even on systems without TscInvariant
> > CPU capability. Hence, mark_tsc_unstable() call should be called _after_
> > scheduler clock has been changed to the paravirtualized clocksource. This
> > will prevent any unwanted manipulation of the sched_clock. Only TSC will
> > be correctly marked as unstable.
>
> Correct me if I'm wrong, what you're trying to address is that
> sched_clock remains marked as unstable even after Linux has switched to
> a stable clock source.
>
> I think a better approach will be to mark the sched_clock as stable when
> we switch to the paravirtualized clock source.
No.. unstable->stable transitions are unsound. You get to switch to your
paravirt clock earlier.
next prev parent reply other threads:[~2021-07-13 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 3:05 [PATCH] Hyper-V: fix for unwanted manipulation of sched_clock when TSC marked unstable Ani Sinha
2021-07-13 13:04 ` Wei Liu
2021-07-13 13:17 ` Peter Zijlstra [this message]
2021-07-13 15:31 ` Ani Sinha
2021-07-13 15:47 ` Wei Liu
2021-07-13 17:25 ` Michael Kelley
2021-07-13 17:32 ` Wei Liu
2021-07-13 17:48 ` Ani Sinha
2021-07-13 18:30 ` Michael Kelley
2021-07-14 3:16 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713131756.GD4170@worktop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ani@anisinha.ca \
--cc=anirban.sinha@nokia.com \
--cc=bp@alien8.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=sthemmin@microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox