From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADED6C11F66 for ; Wed, 14 Jul 2021 18:52:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 942AD61377 for ; Wed, 14 Jul 2021 18:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbhGNSzO (ORCPT ); Wed, 14 Jul 2021 14:55:14 -0400 Received: from foss.arm.com ([217.140.110.172]:38422 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbhGNSzM (ORCPT ); Wed, 14 Jul 2021 14:55:12 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 23136D6E; Wed, 14 Jul 2021 11:52:20 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 417A83F774; Wed, 14 Jul 2021 11:52:19 -0700 (PDT) Date: Wed, 14 Jul 2021 19:52:16 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J . Wysocki" , Jassi Brar Subject: Re: [PATCH 12/13] mailbox: pcc: Add support for PCCT extended PCC subspaces(type 3/4) Message-ID: <20210714185216.GE49078@e120937-lin> References: <20210708180851.2311192-1-sudeep.holla@arm.com> <20210708180851.2311192-13-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210708180851.2311192-13-sudeep.holla@arm.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 08, 2021 at 07:08:50PM +0100, Sudeep Holla wrote: > With all the plumbing in place to avoid accessing PCCT type and other > fields directly from the PCCT table all the time, let us now add the > support for extended PCC subspaces(type 3 and 4). > > Signed-off-by: Sudeep Holla > --- Hi Sudeep, just a few general observation on Type 3/4 subspaces from the spec Table 14.7: - "If a slave-subspace is present in the PCCT, then the platform interrupt flag must be set to 1." table 14.7 Maybe is worth to WARN on this if this assumption is violated by the ACPI table we found. - "Note that if interrupts are edge triggered, then each subspace must have its own unique interrupt." Same here, maybe it's worth also to check this, so that after all the pchan->db_irq has been obtained no edge triggered irqs are duplicated before requesting them. Thanks, Cristian