Re: [PATCH v2 0/6] block: add error handling for *add_disk*()

Luis Chamberlain
2021-07-15T19:52:37Z

On Thu, Jul 15, 2021 at 08:23:00AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 14, 2021 at 09:55:25PM -0700, Luis Chamberlain wrote:
> > Although I've dropped driver conversion at this point I've
> > converted all drivers over, but that series is about 80
> > patches... and so should be dealt with after this basic core
> > work is reviewed and merged.
>
> I think we need at least a few sample conversions to show how
> you intend this to be used.

I'll send a few out, but I'll send them as separate groups. There
are 5 groups of further changes as part of the driver conversion:

1) trivial changes: requires a blk_cleanup_disk() on error added
2) Fix uses of GENHD_FL_UP
3) Fix uses of GENHD_FL_UP for del_gendisk() with a block helper
4) make probe on blk_request_module() return an error, so to
take advantage of the add_disk() on probe calls. Drivers which
benefit:
- ataflop
- brd
- floppy
- loop
- scsi/sd
5) Once all drivers are converted, add __must_check() to add_disk()
and friends

There are so many patches I think it makes sense to only post a few
for each group, except maybe the 4th group, that requires probe
change to go in one full sweep. I've only build tested what fits
in my architecture so far, waiting on 0-day complaints reports to
fix the rest. So only the first first group will go as PATCH form
for now.

Luis