From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C71C07E96 for ; Thu, 15 Jul 2021 10:08:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FEC2613BB for ; Thu, 15 Jul 2021 10:08:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241198AbhGOKLp (ORCPT ); Thu, 15 Jul 2021 06:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231442AbhGOKLo (ORCPT ); Thu, 15 Jul 2021 06:11:44 -0400 Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AAB2C06175F for ; Thu, 15 Jul 2021 03:08:51 -0700 (PDT) Received: by mail-wm1-x32b.google.com with SMTP id n4so3366233wms.1 for ; Thu, 15 Jul 2021 03:08:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ijtb4G/hc385IfMsMOWiOrnQJxdpMd4D8+Ng3Od+NqY=; b=nWzuVxoMT4VHpZmeLo/Q7mlUv4y3HfNEyAMWJHyFUoEfnNtYSL8BiRcgbBa1D2CX36 pN4sy0UnAIimZpctKZFLBfkk7Vty7B/YguVRWwkkLpD6/Eybqh/7TPPZf9wanvUlEKCY cZ4qDDDKZevVivJKaqZ3b0cCYTtGwPE6ymEOt30/gkr3/IHznyxskpxTtQDbJ3RnYdnz vZv42avJDJSH840BetqPwbG8n263PR45UjIz9UrwelC7n4FBlv224QXii3UKI2oWAYGH F6dbnwjuhij+Om051vLdJQUSCXripwOySTmKkO6nWAUoZOaie4N5Hsa/zZRCKshVjB4v 4Ohw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ijtb4G/hc385IfMsMOWiOrnQJxdpMd4D8+Ng3Od+NqY=; b=E3ChpczNqVOf7bECpTvBLfNMPTXy9hyOU0savRvekaOlb6dCp61s+xIfm+C457l9S+ id+TipyWwU83HMCPyMdwUZfhhWTjzXk9O0GHtuePoc97rkSHSAl7d7Gpg9cCY1plkjcE ndTO01e/+L2zVpbmG7x3zON281Th35YviojdY5lsm7LU+gkuICl4aFCyXr0/nEQ6b5yy D9vDtrcIF1jd2IfctXPY3vY5OgfCmtQuAamidO1SuGFWdUytggeIve+dyJfx4ltvpaEi aNvlwlhWQ20PhyNeAGRXWoATZafnGCuZFS4/5L0pTQPPPHXHA5whiwV/0y19m1BGHIWr MegA== X-Gm-Message-State: AOAM532JdN6THInfs7QZC5flMhXnOK+OymaQ70R1eYay71DqvLSvecGW azSchZAl6tac6g3IIupEDio= X-Google-Smtp-Source: ABdhPJzAamOVpXRifsiGGIubtfoku+yCSTTrFqsVPVd0CUWZsaW4V8dr7txB0XluBaZFNatPDevcmw== X-Received: by 2002:a05:600c:1546:: with SMTP id f6mr3661109wmg.164.1626343730218; Thu, 15 Jul 2021 03:08:50 -0700 (PDT) Received: from agape.jhs ([5.171.89.158]) by smtp.gmail.com with ESMTPSA id k13sm6226074wrp.34.2021.07.15.03.08.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Jul 2021 03:08:50 -0700 (PDT) Date: Thu, 15 Jul 2021 12:08:47 +0200 From: Fabio Aiuto To: Colin Ian King Cc: Quytelda Kahja , Greg Kroah-Hartman , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: Re: staging: rtl8723bs mask values in wpa_set_auth_algs Message-ID: <20210715100846.GA2271@agape.jhs> References: <619462ca-e652-30f5-6ffa-3213175d8bbc@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <619462ca-e652-30f5-6ffa-3213175d8bbc@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Colin, On Fri, Jul 09, 2021 at 03:53:39PM +0100, Colin Ian King wrote: > Hi, > > Static analysis with Coverity has found an issue introduced by the > following commit: > > commit 5befa937e8daaebcde81b9423eb93f3ff2e918f7 > Author: Quytelda Kahja > Date: Tue Mar 27 01:41:02 2018 -0700 > > staging: rtl8723bs: Fix IEEE80211 authentication algorithm constants. > > The analysis is as follows: > > 347 static int wpa_set_auth_algs(struct net_device *dev, u32 value) > 348 { > 349 struct adapter *padapter = rtw_netdev_priv(dev); > 350 int ret = 0; > 351 > 352 if ((value & WLAN_AUTH_SHARED_KEY) && (value & WLAN_AUTH_OPEN)) { > > Logically dead code (DEADCODE) > > 353 padapter->securitypriv.ndisencryptstatus = > Ndis802_11Encryption1Enabled; > 354 padapter->securitypriv.ndisauthtype = > Ndis802_11AuthModeAutoSwitch; > 355 padapter->securitypriv.dot11AuthAlgrthm = > dot11AuthAlgrthm_Auto; > 356 } else if (value & WLAN_AUTH_SHARED_KEY) { > 357 padapter->securitypriv.ndisencryptstatus = > Ndis802_11Encryption1Enabled; > 358 > 359 padapter->securitypriv.ndisauthtype = > Ndis802_11AuthModeShared; > 360 padapter->securitypriv.dot11AuthAlgrthm = > dot11AuthAlgrthm_Shared; > dead_error_condition: The condition value & 0U cannot be true. > 361 } else if (value & WLAN_AUTH_OPEN) { > 362 /* padapter->securitypriv.ndisencryptstatus = > Ndis802_11EncryptionDisabled; */ > > Logically dead code (DEADCODE) > > 363 if (padapter->securitypriv.ndisauthtype < > Ndis802_11AuthModeWPAPSK) { > 364 padapter->securitypriv.ndisauthtype = > Ndis802_11AuthModeOpen; > 365 padapter->securitypriv.dot11AuthAlgrthm = > dot11AuthAlgrthm_Open; > 366 } > 367 } else { > 368 ret = -EINVAL; > 369 } > 370 > 371 return ret; > 372 > 373 } > > The deadcode warnings occur because the mask value of WLAN_AUTH_OPEN is > defined in /include/linux/ieee80211.h as: > > #define WLAN_AUTO_OPEN 0 > > and so any value masked with 0 is 0 and hence that part of the if > statement is always false. > > The original code was using the mask values: > > AUTH_ALG_SHARED_KEY and also AUTH_ALG_OPEN_SYSTEM that are defined as: > > #define AUTH_ALG_OPEN_SYSTEM 0x1 > #define AUTH_ALG_SHARED_KEY 0x2 I think that the correct macros are: /* IW_AUTH_80211_AUTH_ALG values (bit field) */ #define IW_AUTH_ALG_OPEN_SYSTEM 0x00000001 #define IW_AUTH_ALG_SHARED_KEY 0x00000002 #define IW_AUTH_ALG_LEAP 0x00000004 defined in include/uapi/linux/wireless.h > > So this appears to be a regression. I'm not sure the best approach for a > suitable fix to use the intended macros in ieee80211.h > > Colin > > > > thank you, fabio