From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F702C07E96 for ; Thu, 15 Jul 2021 14:50:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EE82761360 for ; Thu, 15 Jul 2021 14:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237830AbhGOOxV (ORCPT ); Thu, 15 Jul 2021 10:53:21 -0400 Received: from wtarreau.pck.nerim.net ([62.212.114.60]:57640 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234745AbhGOOxU (ORCPT ); Thu, 15 Jul 2021 10:53:20 -0400 Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 16FEoJbu030676; Thu, 15 Jul 2021 16:50:19 +0200 Date: Thu, 15 Jul 2021 16:50:19 +0200 From: Willy Tarreau To: Andy Shevchenko Cc: Miguel Ojeda , Lars Poeschel , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/1] auxdisplay: charlcd: Drop unneeded initializers and switch to C99 style Message-ID: <20210715145019.GH27830@1wt.eu> References: <20210715144152.83582-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715144152.83582-1-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 05:41:52PM +0300, Andy Shevchenko wrote: > For structure initializers the fields are 0 (or NULL) by default, so > there is no need to fill them explicitly. Besides that, much easier > to read when initializers use C99 style. Hence, convert to C99 style > as well. > > Signed-off-by: Andy Shevchenko Thanks Andy! Acked-by: Willy Tarreau Willy