Re: [PATCH 5.12 000/242] 5.12.18-rc1 review

Greg Kroah-Hartman
2021-07-19T06:10:09Z

On Mon, Jul 19, 2021 at 07:40:21AM +0200, Sven Schnelle wrote:
> Hi Daniel,
>
> Daniel Díaz <daniel.diaz@linaro.org> writes:
>
> > Hello!
> >
> > On Thu, 15 Jul 2021 at 13:56, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> >> This is the start of the stable review cycle for the 5.12.18 release.
> >> There are 242 patches in this series, all will be posted as a response
> >> to this one. If anyone has any issues with these being applied, please
> >> let me know.
> >>
> >> Responses should be made by Sat, 17 Jul 2021 18:21:07 +0000.
> >> Anything received after that time might be too late.
> >>
> >> The whole patch series can be found in one patch at:
> >> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.12.18-rc1.gz
> >> or in the git tree and branch at:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.12.y
> >> and the diffstat can be found below.
> >>
> >> thanks,
> >>
> >> greg k-h
> >
> > Build regressions have been found on this release candidate (and on 5.13-rc).
> >
> > ## Regressions (compared to v5.12.17)
> > * s390, build
> > - clang-10-allnoconfig
> > - clang-10-defconfig
> > - clang-10-tinyconfig
> > - clang-11-allnoconfig
> > - clang-11-defconfig
> > - clang-11-tinyconfig
> > - clang-12-allnoconfig
> > - clang-12-defconfig
> > - clang-12-tinyconfig
> > - gcc-8-allnoconfig
> > - gcc-8-defconfig
> > - gcc-8-tinyconfig
> > - gcc-9-allnoconfig
> > - gcc-9-defconfig
> > - gcc-9-tinyconfig
> > - gcc-10-allnoconfig
> > - gcc-10-defconfig
> > - gcc-10-tinyconfig
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > [...]
> >> Sven Schnelle <svens@linux.ibm.com>
> >> s390/signal: switch to using vdso for sigreturn and syscall restart
> > [...]
> >
> > Our bisections pointed to this commit. Reverting it made the build pass again.
>
> If https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1428532107
> is the logfile for this problem, than i see the following in the log:
>
> make --silent --keep-going --jobs=8 O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=s390 CROSS_COMPILE=s390x-linux-gnu- 'CC=sccache s390x-linux-gnu-gcc' 'HOSTCC=sccache gcc'
> /bin/sh: 1: /builds/linux/arch/s390/kernel/vdso64/gen_vdso_offsets.sh: Permission denied
>
> However, in the patch this script is 755, and other architecture are
> using this for a while now - can you check what the permission are when
> you're trying to build the kernel?

Yes, the problem is that when handling patches, we can not change the
permissions on files. That causes this file to not be added with
execute permissions. This has generally been considered a bad thing
anyway, and other scripts that relied on being executable have been
changed over time to not be that way and be explicitly run by the
calling script.

But it looks like th gen_vdso_offsets.sh script has not been changed on
any arch to do that yet. It is one of the few hold outs.

Also, this feels like a HUGE change for a stable tree, adding new
features like this, are you sure it's all needed?

thanks,

greg k-h