[RFC 0/6] block: enhance use of GENHD_FL_UP

Luis Chamberlain
2021-07-15T20:23:48Z

This is the second group of patches which I'd like some review on as
part of the *add_disk*() error handling conversion. While converting
drivers to add error handling, I noticed some were using the flag
GENHD_FL_UP to see if a block device is ready, or for bringing a
device down, so to call del_gendisk() safely. This first group of
patches just address the few areas where the flag is used directly.

Direct use of the flag GENHD_FL_UP is useful but incorrect as we can
add the flag in a gendisk left half built. Instead, add a flag to
actually represent the desired goal.

The next group will deal with the use of the flag for del_gendisk().

Luis Chamberlain (6):
genhd: update docs for GENHD_FL_UP
block: add flag for add_disk() completion notation
md: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED on is_mddev_broken()
mmc/core/block: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED
nvme: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED
fs/block_dev: replace GENHD_FL_UP with GENHD_FL_DISK_ADDED

block/genhd.c | 8 ++++++++
drivers/md/md.h | 2 +-
drivers/mmc/core/block.c | 2 +-
drivers/nvme/host/core.c | 4 ++--
drivers/nvme/host/multipath.c | 2 +-
fs/block_dev.c | 5 +++--
include/linux/genhd.h | 13 +++++++++++--
7 files changed, 27 insertions(+), 9 deletions(-)

--
2.27.0