Re: [PATCH v14 061/138] mm/migrate: Add folio_migrate_flags()

Zi Yan
2021-07-15T15:55:39Z

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

On 14 Jul 2021, at 23:35, Matthew Wilcox (Oracle) wrote:

> Turn migrate_page_states() into a wrapper around folio_migrate_flags().
> Also convert two functions only called from folio_migrate_flags() to
> be folio-based. ksm_migrate_page() becomes folio_migrate_ksm() and
> copy_page_owner() becomes folio_copy_owner(). folio_migrate_flags()
> alone shrinks by two thirds -- 1967 bytes down to 642 bytes.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> include/linux/ksm.h | 4 +-
> include/linux/migrate.h | 1 +
> include/linux/page_owner.h | 8 ++--
> mm/folio-compat.c | 6 +++
> mm/ksm.c | 31 ++++++++------
> mm/migrate.c | 84 +++++++++++++++++++-------------------
> mm/page_owner.c | 10 ++---
> 7 files changed, 77 insertions(+), 67 deletions(-)

LGTM. Reviewed-by: Zi Yan <ziy@nvidia.com>

—
Best Regards,
Yan, Zi

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]