Re: [PATCH v14 031/138] fs/netfs: Add folio fscache functions

Mike Rapoport
2021-07-21T09:48:12Z

On Thu, Jul 15, 2021 at 04:35:17AM +0100, Matthew Wilcox (Oracle) wrote:
> Match the page writeback functions by adding
> folio_start_fscache(), folio_end_fscache(), folio_wait_fscache() and
> folio_wait_fscache_killable(). Remove set_page_private_2(). Also rewrite
> the kernel-doc to describe when to use the function rather than what the
> function does, and include the kernel-doc in the appropriate rst file.
> Saves 31 bytes of text in netfs_rreq_unlock() due to set_page_fscache()
> calling page_folio() once instead of three times.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
> Documentation/filesystems/netfs_library.rst | 2 +
> include/linux/netfs.h | 75 +++++++++++++--------
> include/linux/pagemap.h | 16 -----
> 3 files changed, 50 insertions(+), 43 deletions(-)

Acked-by: Mike Rapoport <rppt@linux.ibm.com>