Re: [PATCH v14 024/138] mm/filemap: Add folio_end_writeback()

Mike Rapoport
2021-07-20T10:55:34Z

On Thu, Jul 15, 2021 at 04:35:10AM +0100, Matthew Wilcox (Oracle) wrote:
> Add an end_page_writeback() wrapper function for users that are not yet
> converted to folios.
>
> folio_end_writeback() is less than half the size of end_page_writeback()
> at just 105 bytes compared to 228 bytes, due to removing all the
> compound_head() calls. The 30 byte wrapper function makes this a net
> saving of 93 bytes.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jeff Layton <jlayton@kernel.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> Reviewed-by: David Howells <dhowells@redhat.com>
> ---
> include/linux/pagemap.h | 3 ++-
> mm/filemap.c | 43 ++++++++++++++++++++---------------------
> mm/folio-compat.c | 6 ++++++
> 3 files changed, 29 insertions(+), 23 deletions(-)

Acked-by: Mike Rapoport <rppt@linux.ibm.com>