Re: [PATCH v14 017/138] mm/filemap: Add folio_unlock()

Mike Rapoport
2021-07-20T10:48:36Z

On Thu, Jul 15, 2021 at 04:35:03AM +0100, Matthew Wilcox (Oracle) wrote:
> Convert unlock_page() to call folio_unlock(). By using a folio we
> avoid a call to compound_head(). This shortens the function from 39
> bytes to 25 and removes 4 instructions on x86-64. Because we still
> have unlock_page(), it's a net increase of 16 bytes of text for the
> kernel as a whole, but any path that uses folio_unlock() will execute
> 4 fewer instructions.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jeff Layton <jlayton@kernel.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> Reviewed-by: David Howells <dhowells@redhat.com>
> ---
> include/linux/pagemap.h | 3 ++-
> mm/filemap.c | 29 ++++++++++++-----------------
> mm/folio-compat.c | 6 ++++++
> 3 files changed, 20 insertions(+), 18 deletions(-)

Acked-by: Mike Rapoport <rppt@linux.ibm.com>