Re: [PATCH v14 019/138] mm/filemap: Add folio_lock_killable()

David Howells
2021-08-10T15:33:10Z

Matthew Wilcox (Oracle) <willy@infradead.org> wrote:

> This is like lock_page_killable() but for use by callers who
> know they have a folio. Convert __lock_page_killable() to be
> __folio_lock_killable(). This saves one call to compound_head() per
> contended call to lock_page_killable().
>
> __folio_lock_killable() is 19 bytes smaller than __lock_page_killable()
> was. filemap_fault() shrinks by 74 bytes and __lock_page_or_retry()
> shrinks by 71 bytes. That's a total of 164 bytes of text saved.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jeff Layton <jlayton@kernel.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>

Reviewed-by: David Howells <dhowells@redhat.com>