Re: [PATCH v14 022/138] mm/filemap: Add __folio_lock_or_retry()

David Howells
2021-08-10T15:35:56Z

Matthew Wilcox (Oracle) <willy@infradead.org> wrote:

> Convert __lock_page_or_retry() to __folio_lock_or_retry(). This actually
> saves 4 bytes in the only caller of lock_page_or_retry() (due to better
> register allocation) and saves the 14 byte cost of calling page_folio()
> in __folio_lock_or_retry() for a total saving of 18 bytes. Also use
> a bool for the return type.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Jeff Layton <jlayton@kernel.org>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>

Reviewed-by: David Howells <dhowells@redhat.com>