Re: [PATCH v14 040/138] mm/memcg: Convert mem_cgroup_charge() to take a folio

Matthew Wilcox
2021-08-14T01:30:51Z

On Wed, Aug 11, 2021 at 12:54:05PM +0200, Vlastimil Babka wrote:
> > -static int __mem_cgroup_charge(struct page *page, struct mem_cgroup *memcg,
> > +static int __mem_cgroup_charge(struct folio *folio, struct mem_cgroup *memcg,
> > gfp_t gfp)
>
> The git/next version also renames this function to charge_memcg(), why? The new
> name doesn't look that internal as the old one. I don't have a strong opinion
> but CCing memcg maintainers who might.

Ah, this is Suren's fault :-)

https://lore.kernel.org/linux-mm/20210710003626.3549282-2-surenb@google.com/

Renaming it here makes the merge resolution cleaner.