[PATCH v14 133/138] mm: Fix READ_ONLY_THP warning

Matthew Wilcox (Oracle)
2021-07-15T05:26:15Z

These counters only exist if CONFIG_READ_ONLY_THP_FOR_FS is defined,
but we should not warn if the filesystem natively supports THPs.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
---
include/linux/pagemap.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 25b1bf3b1cdb..81cccb708df7 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -146,7 +146,7 @@ static inline void filemap_nr_thps_inc(struct address_space *mapping)
if (!mapping_thp_support(mapping))
atomic_inc(&mapping->nr_thps);
#else
- WARN_ON_ONCE(1);
+ WARN_ON_ONCE(!mapping_thp_support(mapping));
#endif
}

@@ -156,7 +156,7 @@ static inline void filemap_nr_thps_dec(struct address_space *mapping)
if (!mapping_thp_support(mapping))
atomic_dec(&mapping->nr_thps);
#else
- WARN_ON_ONCE(1);
+ WARN_ON_ONCE(!mapping_thp_support(mapping));
#endif
}

--
2.30.2