Re: [PATCH v14 023/138] mm/swap: Add folio_rotate_reclaimable()

David Howells
2021-08-10T15:36:02Z

Matthew Wilcox (Oracle) <willy@infradead.org> wrote:

> Convert rotate_reclaimable_page() to folio_rotate_reclaimable(). This
> eliminates all five of the calls to compound_head() in this function,
> saving 75 bytes at the cost of adding 15 bytes to its one caller,
> end_page_writeback(). We also save 36 bytes from pagevec_move_tail_fn()
> due to using folios there. Net 96 bytes savings.
>
> Also move its declaration to mm/internal.h as it's only used by filemap.c.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Reviewed-by: William Kucharski <william.kucharski@oracle.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Reviewed-by: David Howells <dhowells@redhat.com>