Re: [PATCH v14 097/138] iomap: Pass the iomap_page into iomap_set_range_uptodate

Matthew Wilcox
2021-07-16T03:21:59Z

On Thu, Jul 15, 2021 at 02:21:05PM -0700, Darrick J. Wong wrote:
> On Thu, Jul 15, 2021 at 04:36:23AM +0100, Matthew Wilcox (Oracle) wrote:
> > All but one caller already has the iomap_page, and we can avoid getting
> > it again.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> Took me a while to distinguish iomap_iop_set_range_uptodate and
> iomap_set_range_uptodate, but yes, this looks pretty simple.

Not my favourite naming, but it's a preexisting condition ;-)

Honestly I'd like to rename iomap to blkmap or something.
And iomap_page is now hilariously badly named. But that's kind
of tangential to everything else here.