Re: [PATCH v14 063/138] mm/writeback: Rename __add_wb_stat() to wb_stat_mod()

Vlastimil Babka
2021-08-12T12:21:17Z

On 7/15/21 5:35 AM, Matthew Wilcox (Oracle) wrote:
> Make this look like the newly renamed vmstat functions.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
> include/linux/backing-dev.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h
> index 44df4fcef65c..a852876bb6e2 100644
> --- a/include/linux/backing-dev.h
> +++ b/include/linux/backing-dev.h
> @@ -64,7 +64,7 @@ static inline bool bdi_has_dirty_io(struct backing_dev_info *bdi)
> return atomic_long_read(&bdi->tot_write_bandwidth);
> }
>
> -static inline void __add_wb_stat(struct bdi_writeback *wb,
> +static inline void wb_stat_mod(struct bdi_writeback *wb,
> enum wb_stat_item item, s64 amount)
> {
> percpu_counter_add_batch(&wb->stat[item], amount, WB_STAT_BATCH);
> @@ -72,12 +72,12 @@ static inline void __add_wb_stat(struct bdi_writeback *wb,
>
> static inline void inc_wb_stat(struct bdi_writeback *wb, enum wb_stat_item item)
> {
> - __add_wb_stat(wb, item, 1);
> + wb_stat_mod(wb, item, 1);
> }
>
> static inline void dec_wb_stat(struct bdi_writeback *wb, enum wb_stat_item item)
> {
> - __add_wb_stat(wb, item, -1);
> + wb_stat_mod(wb, item, -1);
> }
>
> static inline s64 wb_stat(struct bdi_writeback *wb, enum wb_stat_item item)
>