From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6743CC07E95 for ; Fri, 16 Jul 2021 05:40:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F9BA613D4 for ; Fri, 16 Jul 2021 05:40:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234182AbhGPFnY (ORCPT ); Fri, 16 Jul 2021 01:43:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:34886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229833AbhGPFnW (ORCPT ); Fri, 16 Jul 2021 01:43:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7B691613DF; Fri, 16 Jul 2021 05:40:25 +0000 (UTC) Date: Fri, 16 Jul 2021 11:10:21 +0530 From: Manivannan Sadhasivam To: Bhaumik Bhatt Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, quic_jhugo@quicinc.com, linux-kernel@vger.kernel.org, loic.poulain@linaro.org Subject: Re: [PATCH v1 2/2] bus: mhi: core: Depict serial number in hexadecimals Message-ID: <20210716054021.GB3323@workstation> References: <1626395276-24171-1-git-send-email-bbhatt@codeaurora.org> <1626395276-24171-3-git-send-email-bbhatt@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1626395276-24171-3-git-send-email-bbhatt@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 15, 2021 at 05:27:56PM -0700, Bhaumik Bhatt wrote: > In order to maintain consistency with the way OEM PK hash is > displayed and improve the current way, depict serial number in > upper case hexadecimals. > > Signed-off-by: Bhaumik Bhatt Just a minor nit, other than that: Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/bus/mhi/core/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c > index 8b4336e..d825a06 100644 > --- a/drivers/bus/mhi/core/init.c > +++ b/drivers/bus/mhi/core/init.c > @@ -94,7 +94,7 @@ static ssize_t serial_number_show(struct device *dev, > struct mhi_device *mhi_dev = to_mhi_device(dev); > struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl; > > - return snprintf(buf, PAGE_SIZE, "Serial Number: %u\n", > + return snprintf(buf, PAGE_SIZE, "Serial Number: 0x%X\n", nit: please use "0x%x" > mhi_cntrl->serial_number); > } > static DEVICE_ATTR_RO(serial_number); > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >