From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71A44C07E95 for ; Fri, 16 Jul 2021 09:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C53D613F0 for ; Fri, 16 Jul 2021 09:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233614AbhGPJ04 (ORCPT ); Fri, 16 Jul 2021 05:26:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:43392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232486AbhGPJ0w (ORCPT ); Fri, 16 Jul 2021 05:26:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2022613D4; Fri, 16 Jul 2021 09:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626427437; bh=SSF2J5AJFadv8lcFZJGE8EsRfI4LjO0tmzEj5iYkobI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NGMn551XD5tSKGn21pbkfq41wRs5x9vdcTeIj802PSKFGPQUA+V++I9JFpHZ0js36 qxoiOZ7z0B9dlW6yYMu7yE5QoygNKMJimPHc5woHTP3V8BiVevxX+uLo9KkpjSW5+0 xfW/sj3qlY0cQQxYoeNNQ8pW+3DrzxFBN4rJyY+6R32f01OlQ9ef1uJD7aaDd+tmLu rRjji/y8V+FNPkmE+98jtykil3eiJNJvmADoHkCkS35GF1xiLgGrxVGb2spwFbk43G vUKt7OwnUYr279kRvh7IxrNq3ZyRL9HlmZESnY2ZrzdgY5xVcKK/QnkY3TGZlbrjLW nyO6gY2CXni/Q== Date: Fri, 16 Jul 2021 14:53:50 +0530 From: Manivannan Sadhasivam To: Amit Pundir Cc: Jassi Brar , Andy Gross , Bjorn Andersson , Dmitry Baryshkov , linux-arm-msm , lkml Subject: Re: [PATCH] mailbox: qcom-ipcc: Enable loading QCOM_IPCC as a module Message-ID: <20210716092350.GG3323@workstation> References: <20210716074946.4093-1-amit.pundir@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210716074946.4093-1-amit.pundir@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 16, 2021 at 01:19:46PM +0530, Amit Pundir wrote: > This patch enables the qcom_ipcc driver to be loaded as a > module. IPCC is fairly core to system, so as such it should > never be unloaded. It registers as a mailbox + irq controller > and the irq controller drivers in kernel are not supposed to > be unloaded as they don't have the visibility over the clients > consuming the irqs. Hence adding supress_bind_attrs to disable > bind/unbind via sysfs. > > Signed-off-by: Amit Pundir Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/mailbox/Kconfig | 2 +- > drivers/mailbox/qcom-ipcc.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig > index b4b780ea2ac8..c9fc06c7e685 100644 > --- a/drivers/mailbox/Kconfig > +++ b/drivers/mailbox/Kconfig > @@ -264,7 +264,7 @@ config SPRD_MBOX > you want to build the Spreatrum mailbox controller driver. > > config QCOM_IPCC > - bool "Qualcomm Technologies, Inc. IPCC driver" > + tristate "Qualcomm Technologies, Inc. IPCC driver" > depends on ARCH_QCOM || COMPILE_TEST > help > Qualcomm Technologies, Inc. Inter-Processor Communication Controller > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index 584700cd1585..f1d4f4679b17 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -277,6 +277,7 @@ static struct platform_driver qcom_ipcc_driver = { > .driver = { > .name = "qcom-ipcc", > .of_match_table = qcom_ipcc_of_match, > + .suppress_bind_attrs = true, > }, > }; > > -- > 2.25.1 >