From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C34AC636C9 for ; Sat, 17 Jul 2021 09:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDFA1613C3 for ; Sat, 17 Jul 2021 09:02:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232734AbhGQJE6 (ORCPT ); Sat, 17 Jul 2021 05:04:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229781AbhGQJE4 (ORCPT ); Sat, 17 Jul 2021 05:04:56 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0EAAAC06175F for ; Sat, 17 Jul 2021 02:02:00 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id b14-20020a1c1b0e0000b02901fc3a62af78so9594383wmb.3 for ; Sat, 17 Jul 2021 02:01:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BD/V7r10o0SqwIvbsFiBdOw23ZNAoZULz/h9vB+2HHE=; b=U5reRpWclLkzod+TaWxDN0aQ6wmjLtlaqBhetuCsE9ylFW4TbYPdTij2kGTVk9Jf6W pKHb9S6Pw4lrCdSYI4MXNCJqBEwYRTRkIN2y/WEw8/LWHdHH5AYIAjzw0UYE803vu23R spvyEeqKhPStD+udGHU4kPQj7+HOtWyN6DeQbO/JEfOFz9qqu5xrs2vOLYP5wmzHxYpz RtkHdR90WN+ebO8ItZkZ4OM0o3GPJcyErxkODLw595wLPB2rzM+J+gVncCQDb7Q9ZnUE h1cCqB3ULHyIprXF90JpsdVsF/m34TDsnf0Zw0+uIylOikxo/PpGleZOFL93+3UpKPR6 +EvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BD/V7r10o0SqwIvbsFiBdOw23ZNAoZULz/h9vB+2HHE=; b=NtoUzkTk/ZSma+4SdFzkw9ik4XB7Kkh/Xdn6dheA3rYLobT6rP24lI2uO1K9IbUdlL nNRaTIt5Qmo5N1Jt9hC2yJP162jSWla/IzAcEn4oUItKK/ig4AXJnTvzYSAzISeyXlzV 8ZubykmBQTE548YmjYz7OTbRq/WvS56CG4MXYM+uvQPMmhrettRk0ka+QqKBMJ4jCeTl 6AxEAc96zzsPQy4Es+D9n4+mtabyJSD3H/jpUWo54dTb3y7SIKoYPMb9FUwnR9ivVLhv ZsyvW9IMyIqWDNX3XKdoE+w9R66hbNlrR9vyp+ErdeEDeHIiRl/V2A4Onptdno6nTYRn igCw== X-Gm-Message-State: AOAM5312X8extmJLC5Bm1otJ2qb1l6Oi40lMwYCitMysh9aBKX2rb+ij f2oTPS8EK1R2OfMUfQYpJqY= X-Google-Smtp-Source: ABdhPJwFoHftpAwcI+2WWHk58jzC0GnymbZGwSTW1b4xuEvH2wNLpsZXkykRzHYXVMF5q2Z2f16JfA== X-Received: by 2002:a7b:cb98:: with SMTP id m24mr15297545wmi.21.1626512518626; Sat, 17 Jul 2021 02:01:58 -0700 (PDT) Received: from agape.jhs ([5.171.72.78]) by smtp.gmail.com with ESMTPSA id h9sm10263619wmb.35.2021.07.17.02.01.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Jul 2021 02:01:58 -0700 (PDT) Date: Sat, 17 Jul 2021 11:01:56 +0200 From: Fabio Aiuto To: Dan Carpenter Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: rtl8723bs: fix camel case issue Message-ID: <20210717090155.GA1409@agape.jhs> References: <20210714152605.GK1931@kadam> <20210714190456.GA1402@agape.jhs> <20210717082901.GM1931@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210717082901.GM1931@kadam> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On Sat, Jul 17, 2021 at 11:29:01AM +0300, Dan Carpenter wrote: > On Wed, Jul 14, 2021 at 09:04:57PM +0200, Fabio Aiuto wrote: > > Hello Dan, > > > > On Wed, Jul 14, 2021 at 06:26:05PM +0300, Dan Carpenter wrote: > > > On Wed, Jul 14, 2021 at 05:11:14PM +0200, Fabio Aiuto wrote: > > > > fix following post commit hook checkpatch issue: > > > > > > > > CHECK: Avoid CamelCase: > > > > 45: FILE: drivers/staging/rtl8723bs/include/ieee80211.h:170: > > > > +#define is_supported_ht(NetType) (((NetType) > > > > & (WIRELESS_11_24N)) ? true : false) > > > > > > > > Signed-off-by: Fabio Aiuto > > > > --- > > > > drivers/staging/rtl8723bs/include/ieee80211.h | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs/include/ieee80211.h > > > > index 8eb0557a077a..b2c1a7dafcee 100644 > > > > --- a/drivers/staging/rtl8723bs/include/ieee80211.h > > > > +++ b/drivers/staging/rtl8723bs/include/ieee80211.h > > > > @@ -167,7 +167,7 @@ enum network_type { > > > > > > > > #define IsSupportedTxCCK(NetType) (((NetType) & (WIRELESS_11B)) ? true : false) > > > > #define IsSupportedTxOFDM(NetType) (((NetType) & (WIRELESS_11G) ? true : false) > > > > > > These are the same. > > > > > > > -#define is_supported_ht(NetType) (((NetType) & (WIRELESS_11_24N)) ? true : false) > > > > +#define is_supported_ht(net_type) (((net_type) & (WIRELESS_11_24N)) ? true : false) > > > > > > > > NetType -> net_type, or did you mean something else? > > Yes. If you're going to change it then change the surrounding code as > well. > > regards, > dan carpenter > ok, will add a patch in next v2, thank you, fabio