Re: [PATCH 04/11] drm: Drop drm_gem_object_put_locked()

Daniel Vetter
2021-07-20T14:15:42Z

On Sat, Jul 17, 2021 at 01:29:06PM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Now that no one is using it, remove it.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>

Yay!

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
> drivers/gpu/drm/drm_gem.c | 22 ----------------------
> include/drm/drm_gem.h | 2 --
> 2 files changed, 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 9989425e9875..c8866788b761 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -974,28 +974,6 @@ drm_gem_object_free(struct kref *kref)
> }
> EXPORT_SYMBOL(drm_gem_object_free);
>
> -/**
> - * drm_gem_object_put_locked - release a GEM buffer object reference
> - * @obj: GEM buffer object
> - *
> - * This releases a reference to @obj. Callers must hold the
> - * &drm_device.struct_mutex lock when calling this function, even when the
> - * driver doesn't use &drm_device.struct_mutex for anything.
> - *
> - * For drivers not encumbered with legacy locking use
> - * drm_gem_object_put() instead.
> - */
> -void
> -drm_gem_object_put_locked(struct drm_gem_object *obj)
> -{
> - if (obj) {
> - WARN_ON(!mutex_is_locked(&obj->dev->struct_mutex));
> -
> - kref_put(&obj->refcount, drm_gem_object_free);
> - }
> -}
> -EXPORT_SYMBOL(drm_gem_object_put_locked);
> -
> /**
> * drm_gem_vm_open - vma->ops->open implementation for GEM
> * @vma: VM area structure
> diff --git a/include/drm/drm_gem.h b/include/drm/drm_gem.h
> index 240049566592..35e7f44c2a75 100644
> --- a/include/drm/drm_gem.h
> +++ b/include/drm/drm_gem.h
> @@ -384,8 +384,6 @@ drm_gem_object_put(struct drm_gem_object *obj)
> __drm_gem_object_put(obj);
> }
>
> -void drm_gem_object_put_locked(struct drm_gem_object *obj);
> -
> int drm_gem_handle_create(struct drm_file *file_priv,
> struct drm_gem_object *obj,
> u32 *handlep);
> --
> 2.31.1
>

--
Daniel Vetter
Software Engineer, Intel Corporation