Re: [PATCH 2/4] net: Adjustment parameters in rtnl_notify()

Rémi Denis-Courmont
2021-07-19T14:42:26Z

Hi,

Le maanantaina 19. heinäkuuta 2021, 15.25.06 EEST Yajun Deng a écrit :
> The fifth parameter alread modify from 'struct nlmsghdr *nlh' to
> 'int report', just adjustment them.

I can't see that anywhere in the patch.

> Add the case the nlh variable is NULL in nlmsg_report().
>
> Signed-off-by: Yajun Deng <yajun.deng@linux.dev>

> diff --git a/net/phonet/pn_netlink.c b/net/phonet/pn_netlink.c
> index 59aebe296890..03e04d0b8453 100644
> --- a/net/phonet/pn_netlink.c
> +++ b/net/phonet/pn_netlink.c
> @@ -38,7 +38,7 @@ void phonet_address_notify(int event, struct net_device
> *dev, u8 addr) goto errout;
> }
> rtnl_notify(skb, dev_net(dev), 0,
> - RTNLGRP_PHONET_IFADDR, NULL, GFP_KERNEL);
> + RTNLGRP_PHONET_IFADDR, 0, GFP_KERNEL);
> return;
> errout:
> rtnl_set_sk_err(dev_net(dev), RTNLGRP_PHONET_IFADDR, err);
> @@ -204,7 +204,7 @@ void rtm_phonet_notify(int event, struct net_device
> *dev, u8 dst) goto errout;
> }
> rtnl_notify(skb, dev_net(dev), 0,
> - RTNLGRP_PHONET_ROUTE, NULL, GFP_KERNEL);
> + RTNLGRP_PHONET_ROUTE, 0, GFP_KERNEL);
> return;
> errout:
> rtnl_set_sk_err(dev_net(dev), RTNLGRP_PHONET_ROUTE, err);

Sorry but I don't like to replace explicit NULL pointers with implicitly
converted zeroes.

--
雷米‧德尼-库尔蒙