From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4
Date: Wed, 21 Jul 2021 18:26:53 +0200 [thread overview]
Message-ID: <20210721162645.GA1395@agape.jhs> (raw)
In-Reply-To: <20210721153550.3624490-1-arnd@kernel.org>
On Wed, Jul 21, 2021 at 05:35:44PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The other rtlwifi drivers already have this, but r8723bs
> was converted to the generic implementation without adding
> the select:
>
> ERROR: modpost: "arc4_crypt" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
> ERROR: modpost: "arc4_setkey" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
>
> Fixes: 1b11e893eda0 ("staging: rtl8723bs: replace private arc4 encryption with in-kernel one")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/staging/rtl8723bs/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index a88467334dac..7eae820eae3b 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -5,6 +5,7 @@ config RTL8723BS
> depends on m
> select WIRELESS_EXT
> select WEXT_PRIV
> + select CRYPTO_LIB_ARC4
> help
> This option enables support for RTL8723BS SDIO drivers, such as
> the wifi found on the 1st gen Intel Compute Stick, the CHIP
> --
> 2.29.2
>
Acked-by: Fabio Aiuto <fabioaiuto83@gmail.com>
thank you,
fabio
prev parent reply other threads:[~2021-07-21 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 15:35 [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_ARC4 Arnd Bergmann
2021-07-21 16:26 ` Fabio Aiuto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721162645.GA1395@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox