Re: [PATCH v6] iomap: support tail packing inline read

Matthew Wilcox
2021-07-22T16:59:11Z

On Thu, Jul 22, 2021 at 06:53:42PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 22, 2021 at 09:51:09AM -0700, Darrick J. Wong wrote:
> > The commit message is a little misleading -- this adds support for
> > inline data pages at nonzero (but page-aligned) file offsets, not file
> > offsets into the page itself. I suggest:
>
> It actually adds both. pos is the offset into the file.

If you want to add support for both, then you need to call
iomap_set_range_uptodate() instead of SetPageUptodate(). Otherwise,
you can set the page uptodate before submitting the bio for the first
half of the page.