From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B60C4338F for ; Fri, 23 Jul 2021 03:59:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F6A560EC0 for ; Fri, 23 Jul 2021 03:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234627AbhGWDTM (ORCPT ); Thu, 22 Jul 2021 23:19:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:37168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234191AbhGWDR4 (ORCPT ); Thu, 22 Jul 2021 23:17:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8FDC960F43; Fri, 23 Jul 2021 03:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627012710; bh=I/+Q/zFFDQxipqZuuw6/+vIJwIvOLyAIjYB2YVACA/g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gSj+Hlbzc/yL30bKBCxS1ivERZtDiR5EOephglpMeaKDv3wqUkkTtRsVMgKUg8tCj 4rvO2AGgitZIdPV/GipDFnb625XOMAJJE8KfGs7jQkJoB6Px2mRTRLJMMYLVOaWCgy RtTdHkhLJrTugbqqZzYdoDKtK+Q0GnQZ5b76Atq+KRJpApet+QRKUNUjAiU2bpWj2l mR+xjW2JAjJ4wu7P0iCEfDRsqrLCf+UMq45Z8d8IU9NVUQpiDiVsSFuTut5pvG7tW1 szQTNUlTxk8SzstQ2k18LtZG3vYNgKnzjyGGEde+rCc2cx2zcCnVAd0uWqMxzHezDC /5bjtMGh9Om5Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hyunchul Lee , Steve French , Sasha Levin , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org Subject: [PATCH AUTOSEL 5.4 11/14] cifs: fix the out of range assignment to bit fields in parse_server_interfaces Date: Thu, 22 Jul 2021 23:58:10 -0400 Message-Id: <20210723035813.531837-11-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210723035813.531837-1-sashal@kernel.org> References: <20210723035813.531837-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hyunchul Lee [ Upstream commit c9c9c6815f9004ee1ec87401ed0796853bd70f1b ] Because the out of range assignment to bit fields are compiler-dependant, the fields could have wrong value. Signed-off-by: Hyunchul Lee Signed-off-by: Steve French Signed-off-by: Sasha Levin --- fs/cifs/smb2ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index bf6b4f71dc58..defee1d208d2 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -498,8 +498,8 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, p = buf; while (bytes_left >= sizeof(*p)) { info->speed = le64_to_cpu(p->LinkSpeed); - info->rdma_capable = le32_to_cpu(p->Capability & RDMA_CAPABLE); - info->rss_capable = le32_to_cpu(p->Capability & RSS_CAPABLE); + info->rdma_capable = le32_to_cpu(p->Capability & RDMA_CAPABLE) ? 1 : 0; + info->rss_capable = le32_to_cpu(p->Capability & RSS_CAPABLE) ? 1 : 0; cifs_dbg(FYI, "%s: adding iface %zu\n", __func__, *iface_count); cifs_dbg(FYI, "%s: speed %zu bps\n", __func__, info->speed); -- 2.30.2