Re: [PATCH v1 1/1] media: ipu3-cio2: Drop reference on error path in cio2_bridge_connect_sensor()

Andy Shevchenko
2021-07-26T11:56:37Z

On Mon, Jul 26, 2021 at 2:47 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
> On Mon, Jul 26, 2021 at 11:40:55AM +0300, Andy Shevchenko wrote:

...

> > err_free_swnodes:
> > software_node_unregister_nodes(sensor->swnodes);
> > err_put_adev:
> > - acpi_dev_put(sensor->adev);
> > + acpi_dev_put(adev);
>
> adev is assigned to sensor->adev before goto so the two have the same
> value. I have no problem with the patch though.

Are we reading the same version? Or am I missing something?

--
With Best Regards,
Andy Shevchenko