Re: [PATCH net-next v3 27/31] dev_ioctl: split out ndo_eth_ioctl

Jason Gunthorpe
2021-07-27T16:30:30Z

On Tue, Jul 27, 2021 at 03:45:13PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Most users of ndo_do_ioctl are ethernet drivers that implement
> the MII commands SIOCGMIIPHY/SIOCGMIIREG/SIOCSMIIREG, or hardware
> timestamping with SIOCSHWTSTAMP/SIOCGHWTSTAMP.
>
> Separate these from the few drivers that use ndo_do_ioctl to
> implement SIOCBOND, SIOCBR and SIOCWANDEV commands.
>
> This is a purely cosmetic change intended to help readers find
> their way through the implementation.
>
> Cc: Doug Ledford <dledford@redhat.com>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Jay Vosburgh <j.vosburgh@gmail.com>
> Cc: Veaceslav Falico <vfalico@gmail.com>
> Cc: Andy Gospodarek <andy@greyhouse.net>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Vivien Didelot <vivien.didelot@gmail.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: Leon Romanovsky <leon@kernel.org>
> Cc: linux-rdma@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Documentation/networking/netdevices.rst | 4 ++
> Documentation/networking/timestamping.rst | 6 +--
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 8 ++--

Acked-by: Jason Gunthorpe <jgg@nvidia.com>

ipoib is a convoluted, but this transform looks OK

Jason