Re: [PATCH v2 1/2] dt-bindings: connector: Add pd-supported property

Guenter Roeck
2021-07-27T16:29:24Z

On 7/27/21 8:13 AM, Kyle Tso wrote:
> Set pd-supported property if the Type-C connector has power delivery
> support.
>
> Signed-off-by: Kyle Tso <kyletso@google.com>
> ---
> .../devicetree/bindings/connector/usb-connector.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/connector/usb-connector.yaml b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> index 92b49bc37939..8ed271feea08 100644
> --- a/Documentation/devicetree/bindings/connector/usb-connector.yaml
> +++ b/Documentation/devicetree/bindings/connector/usb-connector.yaml
> @@ -111,6 +111,10 @@ properties:
> - 1.5A
> - 3.0A
>
> + pd-supported:

I think that would have to be a property indicating that pd is _not_
supported, for compatibility reasons. Otherwise all existing bindings
would indicate that pd is not supported.

> + description: Set this property if the Type-C connector has power delivery support.
> + type: boolean
> +
> # The following are optional properties for "usb-c-connector" with power
> # delivery support.
> source-pdos:
> @@ -312,6 +316,7 @@ examples:
> label = "USB-C";
> power-role = "dual";
> try-power-role = "sink";
> + pd-supported;
> source-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_USB_COMM)>;
> sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_USB_COMM)
> PDO_VAR(5000, 12000, 2000)>;
>