From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB6DC4338F for ; Wed, 28 Jul 2021 12:28:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 437E860FDA for ; Wed, 28 Jul 2021 12:28:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235231AbhG1M2q (ORCPT ); Wed, 28 Jul 2021 08:28:46 -0400 Received: from foss.arm.com ([217.140.110.172]:55960 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235199AbhG1M2o (ORCPT ); Wed, 28 Jul 2021 08:28:44 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A201D31B; Wed, 28 Jul 2021 05:28:42 -0700 (PDT) Received: from e120937-lin (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C4F1E3F70D; Wed, 28 Jul 2021 05:28:39 -0700 (PDT) Date: Wed, 28 Jul 2021 13:28:37 +0100 From: Cristian Marussi To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org, virtio-dev@lists.oasis-open.org, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, f.fainelli@gmail.com, etienne.carriere@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com, igor.skalkin@opensynergy.com, peter.hilber@opensynergy.com, alex.bennee@linaro.org, jean-philippe@linaro.org, mikhail.golubev@opensynergy.com, anton.yakovlev@opensynergy.com, Vasyl.Vavrychuk@opensynergy.com, Andriy.Tryshnivskyy@opensynergy.com Subject: Re: [PATCH v6 05/17] firmware: arm_scmi: Add transport optional init/exit support Message-ID: <20210728122837.GG6592@e120937-lin> References: <20210712141833.6628-1-cristian.marussi@arm.com> <20210712141833.6628-6-cristian.marussi@arm.com> <20210728114018.i7fquzpgfl4qv6tm@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210728114018.i7fquzpgfl4qv6tm@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 28, 2021 at 12:40:18PM +0100, Sudeep Holla wrote: > On Mon, Jul 12, 2021 at 03:18:21PM +0100, Cristian Marussi wrote: > > Some SCMI transport could need to perform some transport specific setup > > before they can be used by the SCMI core transport layer: typically this > > early setup consists in registering with some other kernel subsystem. > > > > Add the optional capability for a transport to provide a couple of .init > > and .exit functions that are assured to be called early during the SCMI > > core initialization phase, well before the SCMI core probing step. > > > > [ Peter: Adapted RFC patch by Cristian for submission to upstream. ] > > Signed-off-by: Peter Hilber > > [ Cristian: Fixed scmi_transports_exit point of invocation ] > > Signed-off-by: Cristian Marussi > > --- > > v4 --> V5 > > - removed useless pr_debug > > - moved scmi_transport_exit() invocation > > --- Hi Sudeep, thanks for having a look. > > drivers/firmware/arm_scmi/common.h | 8 +++++ > > drivers/firmware/arm_scmi/driver.c | 56 ++++++++++++++++++++++++++++++ > > 2 files changed, 64 insertions(+) > > > > diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h > > index 7c2b9fd7e929..6bb734e0e3ac 100644 > > --- a/drivers/firmware/arm_scmi/common.h > > +++ b/drivers/firmware/arm_scmi/common.h > > @@ -321,6 +321,12 @@ struct scmi_device *scmi_child_dev_find(struct device *parent, > > /** > > * struct scmi_desc - Description of SoC integration > > * > > + * @init: An optional function that a transport can provide to initialize some > > + * transport-specific setup during SCMI core initialization, so ahead of > > + * SCMI core probing. > > + * @exit: An optional function that a transport can provide to de-initialize > > + * some transport-specific setup during SCMI core de-initialization, so > > + * after SCMI core removal. > > * @ops: Pointer to the transport specific ops structure > > * @max_rx_timeout_ms: Timeout for communication with SoC (in Milliseconds) > > * @max_msg: Maximum number of messages that can be pending > > @@ -328,6 +334,8 @@ struct scmi_device *scmi_child_dev_find(struct device *parent, > > * @max_msg_size: Maximum size of data per message that can be handled. > > */ > > struct scmi_desc { > > + int (*init)(void); > > + void (*exit)(void); > > Does it make sense to rename scmi_desc as scmi_transport or scmi_transport_desc ? > I reason I ask is plain init/exit here doesn't make sense. You can change it > to transport_init/exit if we don't want to rename the structure. > Yes indeed I'll rename these to transport_init/exit in V7. > > const struct scmi_transport_ops *ops; > > I assume we don't want init/exit inside ops as it is shared with protocols ? > Looks good other than the above comment. > It seemed to me that scmi_transport_ops were more related to an initialized instance of a transport and as such used when the scmi instance is probed or later, while these transport_init/exit are more general transport specific methods that have to be called, if provided, at scmi driver init, way before scmi_probe(), to allow for early transport inits, as an example virtio-scmi uses these to register at first with the virtio subsystem; so I kept them separated. Thanks, Cristian