Re: [PATCH 33/64] lib: Introduce CONFIG_TEST_MEMCPY

Kees Cook
2021-07-28T01:30:17Z

On Tue, Jul 27, 2021 at 04:31:03PM -0700, Bart Van Assche wrote:
> On 7/27/21 1:58 PM, Kees Cook wrote:
> > +static int __init test_memcpy_init(void)
> > +{
> > + int err = 0;
> > +
> > + err |= test_memcpy();
> > + err |= test_memmove();
> > + err |= test_memset();
> > +
> > + if (err) {
> > + pr_warn("FAIL!\n");
> > + err = -EINVAL;
> > + } else {
> > + pr_info("all tests passed\n");
> > + }
> > +
> > + return err;
> > +}
> > +
> > +static void __exit test_memcpy_exit(void)
> > +{ }
> > +
> > +module_init(test_memcpy_init);
> > +module_exit(test_memcpy_exit);
> > +MODULE_LICENSE("GPL");
>
> Has it been considered to implement this test using the Kunit framework?

Good point! I will see if that works here; it would make sense to make
this KUnit from the start.

--
Kees Cook