From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F333AC432BE for ; Thu, 29 Jul 2021 00:13:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8A5660F59 for ; Thu, 29 Jul 2021 00:13:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232895AbhG2ANj (ORCPT ); Wed, 28 Jul 2021 20:13:39 -0400 Received: from conuserg-08.nifty.com ([210.131.2.75]:26564 "EHLO conuserg-08.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232727AbhG2ANe (ORCPT ); Wed, 28 Jul 2021 20:13:34 -0400 Received: from localhost.localdomain (133-32-232-101.west.xps.vectant.ne.jp [133.32.232.101]) (authenticated) by conuserg-08.nifty.com with ESMTP id 16T0Cuue027152; Thu, 29 Jul 2021 09:12:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-08.nifty.com 16T0Cuue027152 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1627517577; bh=YqJ9c/GjkU+qY5J6Ldxh46l7uiwa/TKEk8lJzU+RyjU=; h=From:To:Cc:Subject:Date:From; b=o9d66vvFcU3pe4jIt+V8N0R+pPUCN7g3q2lyRq0IZRE8Yl2VY0ZaZxuyGzkebFFdW b6AgtVcv+qmsbceOGDPXeT/2p+tbR4meBfGdt6Y+M47duWhst4Y8/6Pz/zdA0Lw5IJ cyPxGfTHBqlAAa4djSyd+wsjpJ14Tp2N6ZWB4/f8fJHfciqM2SBmN3unCTlCQbStwb ku6qO7Ag3tVsQ3dGETWuktRruGNIIC/qDCSLVOzVh0NwGku44fax4ozqKnC8Gc9kRY 5XCCGlV0fGhXmYqKwANqOnjEFPAN84aKVAq9m1/AUF+bpNgC5ywd7NclF6EvJIL3cq CWD8fZsAFsBOw== X-Nifty-SrcIP: [133.32.232.101] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Masahiro Yamada , John S Gruber , Michal Marek , linux-kernel@vger.kernel.org Subject: [PATCH] kbuild: cancel sub_make_done for the install target to fix DKMS Date: Thu, 29 Jul 2021 09:12:54 +0900 Message-Id: <20210729001254.327661-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit bcf637f54f6d ("kbuild: parse C= and M= before changing the working directory"), external modules invoked by DKMS fail to build because M= option is not parsed. I wanted to add 'unset sub_make_done' in install.sh but similar scripts, arch/*/boot/install.sh, are duplicated, so I set sub_make_done empty in the top Makefile. Fixes: bcf637f54f6d ("kbuild: parse C= and M= before changing the working directory") Reported-by: John S Gruber Signed-off-by: Masahiro Yamada --- Makefile | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Makefile b/Makefile index bb10a93edf5c..4193092f7c38 100644 --- a/Makefile +++ b/Makefile @@ -1316,6 +1316,16 @@ PHONY += scripts_unifdef scripts_unifdef: scripts_basic $(Q)$(MAKE) $(build)=scripts scripts/unifdef +# --------------------------------------------------------------------------- +# Install + +# Many distros have the custom install script, /sbin/kernelinstall. +# If DKMS is installed, 'make install' will eventually recuses back +# to the this Makefile to build and install external modules. +# Cancel sub_make_done so that options such as M=, V=, etc. are parsed. + +install: sub_make_done= + # --------------------------------------------------------------------------- # Tools -- 2.27.0