Re: [PATCH v6 05/12] dt-bindings: power: supply: smb347-charger: Document USB VBUS regulator

Sebastian Reichel
2021-08-06T21:13:20Z

[-- Attachment #1: Type: text/plain, Size: 3388 bytes --]

Hi,

On Sat, Jul 31, 2021 at 08:38:35PM +0300, Dmitry Osipenko wrote:
> SMB347 can supply power to USB VBUS, which is required by OTG-cable
> devices that want to switch USB port into the host mode. Add USB VBUS
> regulator properties.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> .../power/supply/summit,smb347-charger.yaml | 30 +++++++++++++++++++
> .../dt-bindings/power/summit,smb347-charger.h | 4 +++
> 2 files changed, 34 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> index 983fc215c1e5..20862cdfc116 100644
> --- a/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> +++ b/Documentation/devicetree/bindings/power/supply/summit,smb347-charger.yaml
> @@ -73,6 +73,26 @@ properties:
> - 1 # SMB3XX_SOFT_TEMP_COMPENSATE_CURRENT Current compensation
> - 2 # SMB3XX_SOFT_TEMP_COMPENSATE_VOLTAGE Voltage compensation
>
> + summit,inok-polarity:
> + description: |
> + Polarity of INOK signal indicating presence of external power supply.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum:
> + - 0 # SMB3XX_SYSOK_INOK_ACTIVE_LOW
> + - 1 # SMB3XX_SYSOK_INOK_ACTIVE_HIGH
> +
> + usb-vbus:
> + $ref: "../../regulator/regulator.yaml#"
> + type: object
> +
> + properties:
> + summit,needs-inok-toggle:
> + type: boolean
> + description: INOK signal is fixed and polarity needs to be toggled
> + in order to enable/disable output mode.
> +
> + unevaluatedProperties: false
> +
> allOf:
> - if:
> properties:
> @@ -134,6 +154,7 @@ examples:
> reg = <0x7f>;
>
> summit,enable-charge-control = <SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH>;
> + summit,inok-polarity = <SMB3XX_SYSOK_INOK_ACTIVE_LOW>;
> summit,chip-temperature-threshold-celsius = <110>;
> summit,mains-current-limit-microamp = <2000000>;
> summit,usb-current-limit-microamp = <500000>;
> @@ -141,6 +162,15 @@ examples:
> summit,enable-mains-charging;
>
> monitored-battery = <&battery>;
> +
> + usb-vbus {
> + regulator-name = "usb_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-min-microamp = <750000>;
> + regulator-max-microamp = <750000>;
> + summit,needs-inok-toggle;
> + };
> };
> };
>
> diff --git a/include/dt-bindings/power/summit,smb347-charger.h b/include/dt-bindings/power/summit,smb347-charger.h
> index d918bf321a71..3205699b5e41 100644
> --- a/include/dt-bindings/power/summit,smb347-charger.h
> +++ b/include/dt-bindings/power/summit,smb347-charger.h
> @@ -16,4 +16,8 @@
> #define SMB3XX_CHG_ENABLE_PIN_ACTIVE_LOW 1
> #define SMB3XX_CHG_ENABLE_PIN_ACTIVE_HIGH 2
>
> +/* Polarity of INOK signal */
> +#define SMB3XX_SYSOK_INOK_ACTIVE_LOW 0
> +#define SMB3XX_SYSOK_INOK_ACTIVE_HIGH 1
> +
> #endif
> --
> 2.32.0
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]