Re: [PATCH 3/3] trace: remove redundant dependency from IRQSOFF_TRACER

Steven Rostedt
2021-08-02T13:30:01Z

On Sat, 31 Jul 2021 14:22:33 +0900
Masahiro Yamada <masahiroy@kernel.org> wrote:

> IRQSOFF_TRACE is already guarded by a stronger condition,
> TRACING_SUPPORT.
>
> 'depends on TRACE_IRQFLAGS_SUPPORT' is redundant.

I'm fine with the other two patches, but this one concerns me. I'm not
sure TRACING_SUPPORT really needs to depend on TRACE_IRQFLAGS_SUPPORT.
When tracing was first introduced, the main use case was the irqsoff
tracer. Today, with function graph tracing and events being introduced,
it's one of the minor use cases of tracing support.

I believe the only thing that requires the TRACE_IRQFLAGS_SUPPORT is
the irqsoff tracer (and friends), so if anything, we should remove that
dependency from TRACING_SUPPORT, not here.

-- Steve

>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> kernel/trace/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 9d3f918b5867..b39e67db644e 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -265,7 +265,6 @@ config TRACE_PREEMPT_TOGGLE
> config IRQSOFF_TRACER
> bool "Interrupts-off Latency Tracer"
> default n
> - depends on TRACE_IRQFLAGS_SUPPORT
> select TRACE_IRQFLAGS
> select GENERIC_TRACER
> select TRACER_MAX_TRACE